You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/25 06:10:29 UTC

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4780: [ISSUE #4778] Design of optimize log transfer protocol

lizhanhui commented on code in PR #4780:
URL: https://github.com/apache/rocketmq/pull/4780#discussion_r954537750


##########
common/src/main/java/org/apache/rocketmq/common/EpochEntry.java:
##########
@@ -64,10 +65,10 @@ public void setEndOffset(long endOffset) {
     @Override
     public String toString() {
         return "EpochEntry{" +
-            "epoch=" + epoch +
-            ", startOffset=" + startOffset +
-            ", endOffset=" + endOffset +
-            '}';
+                "epoch=" + epoch +

Review Comment:
   Can we use JSON library to generate string representation instead of manual concatenation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org