[GitHub] [ozone] duongkame commented on a diff in pull request #4448: HDDS-7922. [FSO] S3G folder support fso layout filestatus s3A compatibility

["duongkame (via GitHub)" <gi...@apache.org>]

duongkame commented on code in PR #4448:
URL: https://github.com/apache/ozone/pull/4448#discussion_r1152280809


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -462,6 +476,20 @@ public Response head(
     OzoneKey key;
     try {
       key = getClientProtocol().headS3Object(bucketName, keyPath);
+
+      /*
+        Necessary for directories in buckets with FSO layout.
+        Intended for apps which use Hadoop S3A.
+        Example of such app is Trino (through Hive connector).
+       */
+      boolean isFsoDirCreationEnabled = ozoneConfiguration

Review Comment:
   nit: to avoid duplication, this can be extracted as a function with `isFile` and `keyPath` as parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org