You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/09 07:54:30 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #72: chore: support to use kustomize install all resources
tokers opened a new pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72
Closing #54 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#discussion_r539141090
##########
File path: docs/develop.md
##########
@@ -36,65 +36,8 @@ Configure the service address of Apache APISIX to conf/apisix/base_url ($GOPATH/
* Create CRDs
-```yaml
-kubectl apply -f - <<EOF
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixroutes.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixroutes
- singular: apisixroute
- kind: ApisixRoute
- shortNames:
- - ar
-
----
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixservices.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixservices
- singular: apisixservice
- kind: ApisixService
- shortNames:
- - as
-
----
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixupstreams.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixupstreams
- singular: apisixupstream
- kind: ApisixUpstream
- shortNames:
- - au
-
-EOF
+```
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#discussion_r539121877
##########
File path: docs/develop.md
##########
@@ -36,65 +36,8 @@ Configure the service address of Apache APISIX to conf/apisix/base_url ($GOPATH/
* Create CRDs
-```yaml
-kubectl apply -f - <<EOF
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixroutes.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixroutes
- singular: apisixroute
- kind: ApisixRoute
- shortNames:
- - ar
-
----
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixservices.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixservices
- singular: apisixservice
- kind: ApisixService
- shortNames:
- - as
-
----
-apiVersion: apiextensions.k8s.io/v1beta1
-kind: CustomResourceDefinition
-metadata:
- name: apisixupstreams.apisix.apache.org
-spec:
- group: apisix.apache.org
- versions:
- - name: v1
- served: true
- storage: true
- scope: Namespaced
- names:
- plural: apisixupstreams
- singular: apisixupstream
- kind: ApisixUpstream
- shortNames:
- - au
-
-EOF
+```
Review comment:
add `shell`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741607323
love this PR, need @gxthrj confirm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741622847
> please remove Chinese doc
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj edited a comment on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741620525
yes， we can remove it , and the content has been moved to `usage.md` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj edited a comment on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741620525
Yes, we can remove it , and the content has been moved to `usage.md` and `install.md`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] moonming commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741615923
please remove Chinese doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741616638
> please remove Chinese doc
@gxthrj The deploy.md is written in Chinese, is this deliberate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj edited a comment on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741620525
Yes, we can remove it , and the content has been moved to `usage.md` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741616924
Contents in deploy.md is highly duplicated with others, maybe we can just remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741626994
@tokers you delete file `docs/deploy.md`, I think we need to update some documents that link to this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741634585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #72: chore: support to use kustomize install all resources
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #72:
URL: https://github.com/apache/apisix-ingress-controller/pull/72#issuecomment-741620525
yes， we can remove it , and the content is moved to `usage.md` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org