You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/02/09 02:21:55 UTC
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep simple. There is no reason to use angular inject since
- it can make human-error (e.g. fixing only inject while doesn't modify function args.)
- ngInject is a way to enforce single source of truth (function args)
- we are already applying [ng-annotate](https://github.com/olov/ng-annotate) in webpack. (https://github.com/apache/zeppelin/blob/0589e27e7bb84ec81e1438bcbf3f2fd80ee5a963/zeppelin-web/webpack.config.js#L142)
### What type of PR is it?
[Improvement]
### What is the Jira issue?
MINOR
### How should this be tested?
will be tested by CI
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin MINOR/remove-angular-inject
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1994
----
commit b880905dcc9032b8be960a8f0cf45d0a108b640f
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-09T02:16:15Z
chore: Remove angular inject with ngInject
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep simple. There is no reason to use angular inject since
- it can make human-error (e.g. fixing only inject while doesn't modify function args.)
- ngInject is a way to enforce single source of truth (function args)
- we are already applying [ng-annotate](https://github.com/olov/ng-annotate) in webpack. (https://github.com/apache/zeppelin/blob/0589e27e7bb84ec81e1438bcbf3f2fd80ee5a963/zeppelin-web/webpack.config.js#L142)
```javascript
ParagraphCtrl.$inject = [
'$scope',
'$rootScope',
'$route',
'$window',
'$routeParams',
'$location',
'$timeout',
'$compile',
'$http',
'$q',
'websocketMsgSrv',
'baseUrlSrv',
'ngToast',
'saveAsService',
'noteVarShareService',
'heliumService'
];
// can be replaced with one line
'ngInject';
```
### What type of PR is it?
[Improvement]
### What is the Jira issue?
MINOR
### How should this be tested?
will be tested by CI
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin MINOR/remove-angular-inject
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1994
----
commit b880905dcc9032b8be960a8f0cf45d0a108b640f
Author: 1ambda <1a...@gmail.com>
Date: 2017-02-09T02:16:15Z
chore: Remove angular inject with ngInject
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep simple. There is no reason to use angular inject since
- it can make human-error (e.g. fixing only inject while doesn't modify function args.)
- ngInject is a way to enforce single source of truth (function args)
- we are already applying [ng-annotate](https://github.com/olov/ng-annotate) in webpack. (https://github.com/apache/zeppelin/blob/0589e27e7bb84ec81e1438bcbf3f2fd80ee5a963/zeppelin-web/webpack.config.js#L142)
```javascript
ParagraphCtrl.$inject = [
'$scope',
'$rootScope',
'$route',
'$window',
'$routeParams',
'$location',
'$timeout',
'$compile',
'$http',
'$q',
'websocketMsgSrv',
'baseUrlSrv',
'ngToast',
'saveAsService',
'noteVarShareService',
'heliumService'
];
// can be replaced with one line
'ngInject';
```
### What type of PR is it?
[Improvement]
### What is the Jira issue?
MINOR
### How should this be tested?
will be tested by CI
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin MINOR/remove-angular-inject
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1994
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1994: [MINOR] Replace angular inject with ngInject
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1994: [MINOR] Replace angular inject with ngInject
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1994
@1ambda Thanks for the improvement.
LGTM and merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---