You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by Doug MacEachern <do...@covalent.net> on 2001/08/01 23:48:50 UTC

apr_uri naming

the UNP_* flags should probably have an APR_URI_ (or APU_URI_?) prefix.
whats with APU_URI anyhow, if we have apr_uri_components.  doesn't matter
to me which, but it should be one or the other, apu or apr?

and the in the move, the functions were not properly renamed, eg.
apr_uri_unparse_components should be apr_uri_components_unparse
apr_uri_parse_components should be apr_uri_components_parse

tho i'd be even more happy with apr_uri_unparse, apr_uri_parse, etc.
i'm sure everybody is just as tired of renaming stuff, but now is the
time.  how about the following?

#old                                new
APU_URI_*                           APR_URI_*
UNP_OMITUSER                        APR_URI_UNP_OMITUSER
UNP_OMITPASSWORD                    APR_URI_UNP_OMITPASSWORD
UNP_OMITUSERINFO                    APR_URI_UNP_OMITUSERINFO
UNP_REVEALPASSWORD                  APR_URI_UNP_REVEALPASSWORD
UNP_OMITPATHINFO                    APR_URI_UNP_OMITPATHINFO
UNP_OMITQUERY                       APR_URI_UNP_OMITQUERY
apr_uri_components                  apr_uri_t
apr_uri_unparse_components          apr_uri_unparse
apr_uri_parse_components            apr_uri_parse
apr_uri_parse_hostinfo_components   apr_uri_parse_hostinfo

Re: apr_uri naming

Posted by Justin Erenkrantz <je...@ebuilt.com>.

On Wed, Aug 01, 2001 at 02:48:50PM -0700, Doug MacEachern wrote:
> tho i'd be even more happy with apr_uri_unparse, apr_uri_parse, etc.
> i'm sure everybody is just as tired of renaming stuff, but now is the
> time.  how about the following?
> 
> #old                                new
> APU_URI_*                           APR_URI_*
> UNP_OMITUSER                        APR_URI_UNP_OMITUSER
> UNP_OMITPASSWORD                    APR_URI_UNP_OMITPASSWORD
> UNP_OMITUSERINFO                    APR_URI_UNP_OMITUSERINFO
> UNP_REVEALPASSWORD                  APR_URI_UNP_REVEALPASSWORD
> UNP_OMITPATHINFO                    APR_URI_UNP_OMITPATHINFO
> UNP_OMITQUERY                       APR_URI_UNP_OMITQUERY
> apr_uri_components                  apr_uri_t
> apr_uri_unparse_components          apr_uri_unparse
> apr_uri_parse_components            apr_uri_parse
> apr_uri_parse_hostinfo_components   apr_uri_parse_hostinfo

+1.  

(When I moved it, I was trying to keep the names as similar as possible
to the old ones...)  -- justin