[GitHub] [arrow] chrish42 commented on pull request #7110: ARROW-8952: [C++] WIP Support for textual, JSON schema representation

[GitBox <gi...@apache.org>]

chrish42 commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-639753240


   Okay, even more work-in-progress than the usual, but pushing here to ask for some CMake advice. Basically, I've moved things to a member function of the Schema class (that works). Then I tried to get rid of the hack to load the Flatbuffer Schema.fbs definition, by embedding a copy in a string at compile time, via a flatbuffer_schema.cc.in file, and then linking that in.
   
   Unfortunately, I clearly don't know enough about CMake. The corresponding flatbuffer_schema.cc does get created, with the right content. However, it never gets compiled into an object file, or included in the list of files to link in libarrow.a, etc. It seems like the build system has just chosen to silently ignore that file. Because I only get an error about a missing symbol at link time (instead of "cannot file this object file", say). Anyone who's better at CMake than me?
   
   Otherwise, we can also discuss the name and signature of the member functions: `ToJson` and `FromJson` good? How do they report errors? For the rest, however, please ignore until that "use a schema string" piece is working. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org