You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Joseph K. Bradley (JIRA)" <ji...@apache.org> on 2014/10/23 21:01:33 UTC
[jira] [Comment Edited] (SPARK-4022) Replace colt dependency (LGPL)
with commons-math
[ https://issues.apache.org/jira/browse/SPARK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181777#comment-14181777 ]
Joseph K. Bradley edited comment on SPARK-4022 at 10/23/14 7:00 PM:
--------------------------------------------------------------------
Hi Sean, Thanks for picking this up! W.r.t. the RandomForestSuite failure, I agree that the test is likely flaky since it relies on choosing random subsets of the features. That test actually does not really need to call validateClassifier; the test was to check for a bug in training which caused an exception previously. It should be fine to change (in that test in RandomForestSuite.scala):
from {code}RandomForestSuite.validateClassifier(model, arr, 1.0){code}
to {code}RandomForestSuite.validateClassifier(model, arr, 0.0){code}
was (Author: josephkb):
Hi Sean, Thanks for picking this up! W.r.t. the RandomForestSuite failure, I agree that the test is likely flaky since it relies on choosing random subsets of the features. That test actually does not really need to call validateClassifier; the test was to check for a bug in training which caused an exception previously. It should be fine to change (in that test in RandomForestSuite.scala):
from ```RandomForestSuite.validateClassifier(model, arr, 1.0)```
to ```RandomForestSuite.validateClassifier(model, arr, 0.0)```
> Replace colt dependency (LGPL) with commons-math
> ------------------------------------------------
>
> Key: SPARK-4022
> URL: https://issues.apache.org/jira/browse/SPARK-4022
> Project: Spark
> Issue Type: Bug
> Components: MLlib, Spark Core
> Reporter: Patrick Wendell
> Assignee: Sean Owen
> Priority: Critical
>
> The colt library we use is LGPL-licensed:
> http://acs.lbl.gov/ACSSoftware/colt/license.html
> We need to swap this out for commons-math. It is also a very old library that hasn't been updated since 2004.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org