You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/02 23:25:45 UTC
Review Request 31644: Fixed Master::finalize() to remove slaves and
frameworks from the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31644/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2403
https://issues.apache.org/jira/browse/MESOS-2403
Repository: mesos
Description
-------
This is a short term fix for MESOS-2403.
Diffs
-----
src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892
Diff: https://reviews.apache.org/r/31644/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 31644: Fixed Master::finalize() to remove slaves
and frameworks from the allocator.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 2, 2015, 10:46 p.m., Ben Mahler wrote:
> > src/master/master.cpp, line 773
> > <https://reviews.apache.org/r/31644/diff/1/?file=882398#file882398line773>
> >
> > It seems a bit weird to remove the slave while there are still tasks and executors that need to be removed. Do you think we need the same comment as in removeSlave?
> >
> > ```
> > // We want to remove the slave first, to avoid the allocator
> > // re-allocating the recovered resources.
> > ```
done.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31644/#review74842
-----------------------------------------------------------
On March 2, 2015, 10:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31644/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 10:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2403
> https://issues.apache.org/jira/browse/MESOS-2403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a short term fix for MESOS-2403.
>
>
> Diffs
> -----
>
> src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892
>
> Diff: https://reviews.apache.org/r/31644/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 31644: Fixed Master::finalize() to remove slaves
and frameworks from the allocator.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31644/#review74842
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/31644/#comment121625>
It seems a bit weird to remove the slave while there are still tasks and executors that need to be removed. Do you think we need the same comment as in removeSlave?
```
// We want to remove the slave first, to avoid the allocator
// re-allocating the recovered resources.
```
- Ben Mahler
On March 2, 2015, 10:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31644/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 10:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2403
> https://issues.apache.org/jira/browse/MESOS-2403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a short term fix for MESOS-2403.
>
>
> Diffs
> -----
>
> src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892
>
> Diff: https://reviews.apache.org/r/31644/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 31644: Fixed Master::finalize() to remove slaves
and frameworks from the allocator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31644/#review74858
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31644]
All tests passed.
- Mesos ReviewBot
On March 2, 2015, 10:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31644/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 10:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2403
> https://issues.apache.org/jira/browse/MESOS-2403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a short term fix for MESOS-2403.
>
>
> Diffs
> -----
>
> src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892
>
> Diff: https://reviews.apache.org/r/31644/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>