You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ju...@apache.org on 2015/10/19 23:07:54 UTC
incubator-reef git commit: [REEF-853] IIMRUClient does not return
httpDriverEndPoint
Repository: incubator-reef
Updated Branches:
refs/heads/master fa271af57 -> 65ecdeea6
[REEF-853] IIMRUClient does not return httpDriverEndPoint
This addressed the issue by
* Introducing a new member DriverHttpEndPoint in the IIMRUClient interface. This member/field is assigned after job is submitted.
JIRA:
[REEF-853](https://issues.apache.org/jira/browse/REEF-853)
This closes #573
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/65ecdeea
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/65ecdeea
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/65ecdeea
Branch: refs/heads/master
Commit: 65ecdeea62c5491830e201cf14dd4d84aa4a32da
Parents: fa271af
Author: Dhruv <dh...@apache.org>
Authored: Thu Oct 15 21:36:16 2015 -0700
Committer: Julia Wang <ju...@microsoft.com>
Committed: Mon Oct 19 14:02:48 2015 -0700
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs | 10 ++++++++++
.../InProcess/InProcessIMRUClient.cs | 11 ++++++++++-
.../OnREEF/Client/REEFIMRUClient.cs | 12 +++++++++++-
3 files changed, 31 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/65ecdeea/lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs b/lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs
index 51682de..74b3efa 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/API/IIMRUClient.cs
@@ -18,6 +18,8 @@
*/
using System.Collections.Generic;
+using Org.Apache.REEF.Client.Common;
+using Org.Apache.REEF.Common.Attributes;
namespace Org.Apache.REEF.IMRU.API
{
@@ -32,5 +34,13 @@ namespace Org.Apache.REEF.IMRU.API
/// <param name="jobDefinition">IMRU job definition</param>
/// <returns>Result of IMRU</returns>
IEnumerable<TResult> Submit<TMapInput, TMapOutput, TResult>(IMRUJobDefinition jobDefinition);
+
+ /// <summary>
+ /// DriverHttpEndPoint returned by IReefClient after job submission
+ /// returning null is a valid option for implementations that do not run on yarn or multi-core
+ /// For example: see InProcessIMRUCLient.cs
+ /// </summary>
+ [Unstable("0.13", "This depends on IREEFClient API which itself in unstable ")]
+ IDriverHttpEndpoint DriverHttpEndpoint { get; }
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/65ecdeea/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs b/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
index 08cf201..c336129 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
@@ -21,6 +21,7 @@ using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
+using Org.Apache.REEF.Client.Common;
using Org.Apache.REEF.IMRU.API;
using Org.Apache.REEF.IMRU.InProcess.Parameters;
using Org.Apache.REEF.IO.PartitionedData;
@@ -44,7 +45,7 @@ namespace Org.Apache.REEF.IMRU.InProcess
public class InProcessIMRUClient : IIMRUClient
{
private static readonly Logger Logger =
- Logger.GetLogger(typeof (InProcessIMRUClient));
+ Logger.GetLogger(typeof(InProcessIMRUClient));
private readonly int _numberOfMappers;
@@ -99,6 +100,14 @@ namespace Org.Apache.REEF.IMRU.InProcess
}
/// <summary>
+ /// DriverHttpEndPoint returned by IReefClient after job submission
+ /// </summary>
+ public IDriverHttpEndpoint DriverHttpEndpoint
+ {
+ get { return null; }
+ }
+
+ /// <summary>
/// We also need IPartition at each map function
/// </summary>
/// <param name="mapConfiguration">Map configuration given by user</param>
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/65ecdeea/lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs
index d178c4f..d8cdf9f 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs
@@ -21,6 +21,7 @@ using System.Data;
using System.Globalization;
using System.Linq;
using Org.Apache.REEF.Client.API;
+using Org.Apache.REEF.Client.Common;
using Org.Apache.REEF.Driver;
using Org.Apache.REEF.IMRU.API;
using Org.Apache.REEF.Driver.Bridge;
@@ -50,6 +51,7 @@ namespace Org.Apache.REEF.IMRU.OnREEF.Client
private readonly IREEFClient _reefClient;
private readonly JobSubmissionBuilderFactory _jobSubmissionBuilderFactory;
private readonly AvroConfigurationSerializer _configurationSerializer;
+ private IDriverHttpEndpoint _httpEndPoint;
[Inject]
private REEFIMRUClient(IREEFClient reefClient, AvroConfigurationSerializer configurationSerializer,
@@ -145,9 +147,17 @@ namespace Org.Apache.REEF.IMRU.OnREEF.Client
.SetJobIdentifier(jobDefinition.JobName)
.Build();
- _reefClient.SubmitAndGetDriverUrl(imruJobSubmission);
+ _httpEndPoint = _reefClient.SubmitAndGetDriverUrl(imruJobSubmission);
return null;
}
+
+ /// <summary>
+ /// DriverHttpEndPoint returned by IReefClient after job submission
+ /// </summary>
+ public IDriverHttpEndpoint DriverHttpEndpoint
+ {
+ get { return _httpEndPoint; }
+ }
}
}
\ No newline at end of file