You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tomás Fernández Löbbe (JIRA)" <ji...@apache.org> on 2018/03/08 22:10:00 UTC
[jira] [Comment Edited] (SOLR-11982) Add support for shards.sort
parameter
[ https://issues.apache.org/jira/browse/SOLR-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391900#comment-16391900 ]
Tomás Fernández Löbbe edited comment on SOLR-11982 at 3/8/18 10:09 PM:
-----------------------------------------------------------------------
Thanks [~emaijala]. Code looks really good. I uploaded the latest patch and left some minor comments there. One thing I'm not 100% convinced yet is the pipe in the syntax. To me, pipe usually means "OR", but in this case, that is not the case, the order of the elements in does affect the output. Your code can also handle the comma separated clauses, so it seems like:
{code:java}shards.sort=replicaType:PULL|TLOG{code}
Is actually the same as
{code:java}shards.sort=replicaType:PULL,replicaType:TLOG{code}
What is the intention of including the pipe then?
was (Author: tomasflobbe):
Thanks [~emaijala]. Code looks really good. I uploaded the latest patch and left some minor comments there. One thing I'm not 100% yet is the pipe in the syntax. To me, pipe usually means "OR", but in this case, that is not the case, the order of the elements in does affect the output. Your code can also handle the comma separated clauses, so it seems like:
{code:java}shards.sort=replicaType:PULL|TLOG{code}
Is actually the same as
{code:java}shards.sort=replicaType:PULL,replicaType:TLOG{code}
What is the intention of including the pipe then?
> Add support for shards.sort parameter
> -------------------------------------
>
> Key: SOLR-11982
> URL: https://issues.apache.org/jira/browse/SOLR-11982
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: 7.3, master (8.0)
> Reporter: Ere Maijala
> Priority: Minor
> Labels: patch-available, patch-with-test
> Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch
>
>
> It would be nice to have the possibility to easily sort the shards in the preferred order e.g. by replica type. The attached patch adds support for {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replicas first with {{shards.sor=replicaType:PULL|TLOG }}(which would mean that NRT replicas wouldn't be hit with queries unless they're the only ones available) and/or to sort by replica location (like preferLocalShards=true but more versatile).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org