You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/30 16:22:08 UTC

[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6317: Core: MetadataUpdateParser should write updates/removals fields rather than updated/removed

singhpk234 commented on code in PR #6317:
URL: https://github.com/apache/iceberg/pull/6317#discussion_r1036180810


##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -664,9 +664,15 @@ public void testSetPropertiesFromJson() {
             "prop1", "val1",
             "prop2", "val2");
     String propsMap = "{\"prop1\":\"val1\",\"prop2\":\"val2\"}";
+
+    // make sure "updated" & "updates" both work

Review Comment:
   nit: 
   ```suggestion
       // make sure reading "updated" & "updates" both work
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org