You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by cm...@apache.org on 2003/07/09 18:36:07 UTC
cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http DefaultHttpClient.java
cmlenz 2003/07/09 09:36:07
Modified: framework/src/java/share/org/apache/cactus
RequestDirectives.java
AbstractWebServerTestCase.java
framework/src/java/share/org/apache/cactus/client/connector/http
DefaultHttpClient.java
Removed: framework/src/test/share/org/apache/cactus
RequestDirectivesTest.java
Log:
Remove functionality related to adding unique IDs to the HTTP communication.
Revision Changes Path
1.3 +1 -23 jakarta-cactus/framework/src/java/share/org/apache/cactus/RequestDirectives.java
Index: RequestDirectives.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/RequestDirectives.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- RequestDirectives.java 26 Jun 2003 22:15:28 -0000 1.2
+++ RequestDirectives.java 9 Jul 2003 16:36:06 -0000 1.3
@@ -90,28 +90,6 @@
}
/**
- * @param theId new id for the test case associated
- * with this request
- */
- public void setId(String theId)
- {
- if (getId() != null)
- {
- throw new IllegalStateException("uniqueId already set!");
- }
- addDirective(HttpServiceDefinition.TEST_ID_PARAM, theId);
- }
-
- /**
- * @return Gets the unique id of the test case
- */
- public String getId()
- {
- return underlyingRequest.getParameterGet(
- HttpServiceDefinition.TEST_ID_PARAM);
- }
-
- /**
* @param theName name of the test class.
*/
public void setClassName(String theName)
1.13 +1 -5 jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebServerTestCase.java
Index: AbstractWebServerTestCase.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebServerTestCase.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- AbstractWebServerTestCase.java 29 Jun 2003 13:48:10 -0000 1.12
+++ AbstractWebServerTestCase.java 9 Jul 2003 16:36:06 -0000 1.13
@@ -65,7 +65,6 @@
import org.apache.cactus.client.connector.http.DefaultHttpClient;
import org.apache.cactus.configuration.WebConfiguration;
-import org.apache.cactus.util.UniqueGenerator;
import org.apache.commons.logging.LogFactory;
/**
@@ -250,9 +249,6 @@
directives.setMethodName(this.getCurrentTestMethod());
directives.setAutoSession(
theRequest.getAutomaticSession() ? "true" : "false");
-
-
- directives.setId(UniqueGenerator.generate(this));
// Add the wrapped test if it is not equal to our current instance
if (isWrappingATest())
1.10 +1 -4 jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http/DefaultHttpClient.java
Index: DefaultHttpClient.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http/DefaultHttpClient.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- DefaultHttpClient.java 29 Jun 2003 17:14:00 -0000 1.9
+++ DefaultHttpClient.java 9 Jul 2003 16:36:07 -0000 1.10
@@ -230,9 +230,6 @@
resultsRequest.setRedirectorName(
theOriginalRequest.getRedirectorName());
- //also copy the unique id to get the correct test results
- directives.setId(new RequestDirectives(theOriginalRequest).getId());
-
// Add authentication details
if (theOriginalRequest.getAuthentication() != null)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http DefaultHttpClient.java
Posted by Lesiecki Nicholas <nd...@yahoo.com>.
Thanks Chris!
Cheers,
nick
--- cmlenz@apache.org wrote:
> cmlenz 2003/07/09 09:36:07
>
> Modified: framework/src/java/share/org/apache/cactus
> RequestDirectives.java
> AbstractWebServerTestCase.java
>
> framework/src/java/share/org/apache/cactus/client/connector/http
> DefaultHttpClient.java
> Removed: framework/src/test/share/org/apache/cactus
> RequestDirectivesTest.java
> Log:
> Remove functionality related to adding unique IDs to the HTTP
> communication.
>
> Revision Changes Path
> 1.3 +1 -23
>
jakarta-cactus/framework/src/java/share/org/apache/cactus/RequestDirectives.java
>
> Index: RequestDirectives.java
> ===================================================================
> RCS file:
>
/home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/RequestDirectives.java,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- RequestDirectives.java 26 Jun 2003 22:15:28 -0000 1.2
> +++ RequestDirectives.java 9 Jul 2003 16:36:06 -0000 1.3
> @@ -90,28 +90,6 @@
> }
>
> /**
> - * @param theId new id for the test case associated
> - * with this request
> - */
> - public void setId(String theId)
> - {
> - if (getId() != null)
> - {
> - throw new IllegalStateException("uniqueId already set!");
> - }
> - addDirective(HttpServiceDefinition.TEST_ID_PARAM, theId);
> - }
> -
> - /**
> - * @return Gets the unique id of the test case
> - */
> - public String getId()
> - {
> - return underlyingRequest.getParameterGet(
> - HttpServiceDefinition.TEST_ID_PARAM);
> - }
> -
> - /**
> * @param theName name of the test class.
> */
> public void setClassName(String theName)
>
>
>
> 1.13 +1 -5
>
jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebServerTestCase.java
>
> Index: AbstractWebServerTestCase.java
> ===================================================================
> RCS file:
>
/home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebServerTestCase.java,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -r1.12 -r1.13
> --- AbstractWebServerTestCase.java 29 Jun 2003 13:48:10 -0000 1.12
> +++ AbstractWebServerTestCase.java 9 Jul 2003 16:36:06 -0000 1.13
> @@ -65,7 +65,6 @@
>
> import org.apache.cactus.client.connector.http.DefaultHttpClient;
> import org.apache.cactus.configuration.WebConfiguration;
> -import org.apache.cactus.util.UniqueGenerator;
> import org.apache.commons.logging.LogFactory;
>
> /**
> @@ -250,9 +249,6 @@
> directives.setMethodName(this.getCurrentTestMethod());
> directives.setAutoSession(
> theRequest.getAutomaticSession() ? "true" : "false");
> -
> -
> - directives.setId(UniqueGenerator.generate(this));
>
> // Add the wrapped test if it is not equal to our current
> instance
> if (isWrappingATest())
>
>
>
> 1.10 +1 -4
>
jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http/DefaultHttpClient.java
>
> Index: DefaultHttpClient.java
> ===================================================================
> RCS file:
>
/home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/client/connector/http/DefaultHttpClient.java,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -r1.9 -r1.10
> --- DefaultHttpClient.java 29 Jun 2003 17:14:00 -0000 1.9
> +++ DefaultHttpClient.java 9 Jul 2003 16:36:07 -0000 1.10
> @@ -230,9 +230,6 @@
> resultsRequest.setRedirectorName(
> theOriginalRequest.getRedirectorName());
>
> - //also copy the unique id to get the correct test results
> - directives.setId(new
> RequestDirectives(theOriginalRequest).getId());
> -
> // Add authentication details
> if (theOriginalRequest.getAuthentication() != null)
> {
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org