You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/08 15:05:54 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
adoroszlai opened a new pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
## What changes were proposed in this pull request?
Make `ozone getconf -confKey` return error (255) instead of success (0) for missing key, to be compatible with Ozone 1.0.
https://issues.apache.org/jira/browse/HDDS-4325
## How was this patch tested?
Manually verified that output and exit codes with patch:
```
$ ozone getconf -confKey asdf; echo $?
Configuration asdf is missing.
255
$ ozone getconf -confKey ozone.om.address; echo $?
om
0
```
match 1.0.0:
```
$ ozone getconf -confKey asdf; echo $?
Configuration asdf is missing.
255
$ ozone getconf -confKey ozone.om.address; echo $?
om
0
```
Added check for exit code in acceptance test case for missing key. Also added test case for existing key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705710675
Thanks @umamaheswararao for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] umamaheswararao commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705697044
Thanks @adoroszlai for working on this. The changes looks good to me.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] umamaheswararao commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705697044
Thanks @adoroszlai for working on this. The changes looks good to me.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705710675
Thanks @umamaheswararao for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] umamaheswararao merged pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] umamaheswararao merged pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #1485:
URL: https://github.com/apache/hadoop-ozone/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org