You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/02/02 09:21:44 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #33886: GH-33699: [C++] Increase timeout of c++ tests when running under valgrind and shorten long tests

pitrou commented on code in PR #33886:
URL: https://github.com/apache/arrow/pull/33886#discussion_r1094239133


##########
cpp/src/arrow/compute/kernels/vector_sort_test.cc:
##########
@@ -45,6 +45,15 @@ using internal::checked_pointer_cast;
 
 namespace compute {
 
+#ifdef ARROW_VALGRIND
+using RealArrowTypes = ::testing::Types<FloatType>;

Review Comment:
   Ah, I didn't know you could redefine an alias with `using`.
   As a style note, I would personally prefer if this created a distinct alias, to avoid confusion - and potential leaking accross unity builds?
   (e.g. replace `RealArrowTypes` with `RealSortTypes` or something)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org