[GitHub] [tvm] csullivan commented on pull request #14950: [Bugfix] Avoid symbol conflicts in MakePackedAPI/MakeUnpackedAPI

["csullivan (via GitHub)" <gi...@apache.org>]

csullivan commented on PR #14950:
URL: https://github.com/apache/tvm/pull/14950#issuecomment-1563592694

   Thanks @tqchen. Yeah, had the same thought when discussing offline with @Lunderberg but perhaps we can remove MakeUnpackedAPI altogether later.
   
   In discussing with @Lunderberg it seems the special case handling MakeUnpackedAPI introduces for AOT should be able to be removed once annotations are used for whether a function requires packing or not. MakePackedAPI could then code generate the packed api when the functions are annotated and AOT functions would remain unpacked as they lack the annotation.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org