You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/19 06:44:15 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #38299: [SPARK-40756][SQL] Migrate type check failures of string expressions onto error classes

LuciferYang commented on code in PR #38299:
URL: https://github.com/apache/spark/pull/38299#discussion_r999002118


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -248,11 +248,21 @@
           "The <exprName> must not be null"
         ]
       },
+      "UNEXPECTED_NUM_PARAMS" : {

Review Comment:
   I think we can make `WRONG_NUM_PARAMS` more general



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org