[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121372#comment-16121372 ] 

ASF GitHub Bot commented on FLINK-7408:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4512

    [FLINK-7408] [conf] Create WebOptions for WebRuntimeMonitor

    ## What is the purpose of the change
    
    This commit moves the WebRuntimeMonitor related configuration options from
    JobManagerOptions to WebOptions. Moreover, it removes the prefix jobmanager.
    
    As you've requested @zentol.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink portWebMonitorOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4512
    
----
commit 34c0fcb40f9704f6eab6a9cc520e9a27b91ff0d0
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-10T09:42:09Z

    [FLINK-7408] [conf] Create WebOptions for WebRuntimeMonitor
    
    This commit moves the WebRuntimeMonitor related configuration options from
    JobManagerOptions to WebOptions. Moreover, it removes the prefix jobmanager.

----


> Extract WebRuntimeMonitor options from JobManagerOptions
> --------------------------------------------------------
>
>                 Key: FLINK-7408
>                 URL: https://issues.apache.org/jira/browse/FLINK-7408
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively next to the {{JobManager}}. Therefore, it makes sense to refactor the web monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}} and removing the prefix {{jobmanager}}. 
> This is done as requested by https://github.com/apache/flink/pull/4492#issuecomment-321271819.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)