[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #265: [YUNIKORN-677] Potential resource leak when complete and allocate pod happens simultaneously

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #265:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/265#issuecomment-844698325


   > The check we do for the allocation is in the before hook for task allocated. In that hook we check if the state is task completed. That looks good, however does that cover the fact that a task could already be deleted or is that not a possible case to cover?
   
   Yes, it should be covered. Today, when we delete a pod, that also triggers a CompleteTask event, so the task will be always in the Completed state. This reminds me that we need to do the proper cleanup for the apps in the shim side cache. We can do that when the app is in the terminated state on the core side, so we can safely remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org