You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "caozj1011 (via GitHub)" <gi...@apache.org> on 2023/08/16 09:14:18 UTC
[GitHub] [iotdb] caozj1011 opened a new pull request, #10873: reduce wal log output level
caozj1011 opened a new pull request, #10873:
URL: https://github.com/apache/iotdb/pull/10873
info logs are often printed unnecessarily when no outdated WAL files have been deleted. This fix will reduce the log level to debug. In addition, some optimization of the printed log content.
<img width="1207" alt="image" src="https://github.com/apache/iotdb/assets/34238279/6effc569-3a73-4860-beea-99890e40d290">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #10873: reduce wal log output level
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on code in PR #10873:
URL: https://github.com/apache/iotdb/pull/10873#discussion_r1296010272
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java:
##########
@@ -309,8 +309,8 @@ private void updateEffectiveInfoRationAndUpdateMetric() {
private void summarizeExecuteResult() {
if (filesShouldDelete.length == 0) {
- logger.info(
- "wal node-{}:no wal file was found that should be deleted,current first valid version id is {}",
+ logger.debug(
Review Comment:
if (logger.isDebugEnabled()) {
xxx.
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #10873: reduce wal log output level
Posted by "xingtanzjr (via GitHub)" <gi...@apache.org>.
xingtanzjr merged PR #10873:
URL: https://github.com/apache/iotdb/pull/10873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org