You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2024/08/28 12:06:18 UTC
[PR] Use the new compileResource API when using Daffodil 3.9.0+ [daffodil-sbt]
stevedlawrence opened a new pull request, #49:
URL: https://github.com/apache/daffodil-sbt/pull/49
The compileResource API is useful to create depersonalized diagnostics and saved-parsers.
This modifies the DaffodilPlugin to use compileResource instead of compileSource when creating a saved parser for newer versions of Daffodil. DaffodilSaver must still support older versions of Daffodil that do not have this new API, so the plugin passes in a number to the saver to signify which version of the API to use.
Closes #47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the new compileResource API when using Daffodil 3.9.0+ [daffodil-sbt]
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #49:
URL: https://github.com/apache/daffodil-sbt/pull/49#discussion_r1734566571
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -361,10 +361,26 @@ object DaffodilPlugin extends AutoPlugin {
.map(_.split("\\s+").toSeq)
.getOrElse(Seq.empty)
+ // the DaffodilSaver needs to know which version of Daffodil we are using to create
+ // a saved, since some versions of Daffodil have different APIs and it must use the
Review Comment:
"a saved processor"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the new compileResource API when using Daffodil 3.9.0+ [daffodil-sbt]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #49:
URL: https://github.com/apache/daffodil-sbt/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org