You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "RamiNoodle733 (via GitHub)" <gi...@apache.org> on 2026/02/06 08:01:42 UTC
[PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
RamiNoodle733 opened a new pull request, #37745:
URL: https://github.com/apache/superset/pull/37745
## Summary
This PR renames 'Subtotal' to 'Subvalue' in Pivot Tables and includes the aggregation function name in the label.
## Changes
- Changed column subtotal label from 'Subtotal' to 'Subvalue (%(aggregatorName)s)'
- Changed row subtotal label from 'Subtotal' to 'Subvalue (%(aggregatorName)s)'
## Before
- Subtotal (for any aggregation function)
## After
- Subvalue (Sum)
- Subvalue (Average)
- Subvalue (Count)
- etc.
This change:
1. Renames 'Subtotal' to 'Subvalue' as requested
2. Makes the labeling consistent with how 'Total (Sum)' is displayed
3. Clarifies what aggregation function is being used for the subvalue
Closes #35089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #37745:
URL: https://github.com/apache/superset/pull/37745#issuecomment-3862016105
closing since there are multiple PRs for this fix. It looks like the same pr may have been opened multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37745:
URL: https://github.com/apache/superset/pull/37745#issuecomment-3858695343
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | cc39e1164fc0ba1003f5ae77076167c627ed5be7 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69859fe76796690008e3e100 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37745--superset-docs-preview.netlify.app](https://deploy-preview-37745--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37745--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe closed pull request #37745: fix(pivot-table): rename Subtotal to Subvalue with aggregation function
URL: https://github.com/apache/superset/pull/37745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37745:
URL: https://github.com/apache/superset/pull/37745#issuecomment-3858675921
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot-table): rename Subtotal to Subvalue with aggregation function [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #37745:
URL: https://github.com/apache/superset/pull/37745#discussion_r2772867956
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -718,7 +718,9 @@ export class TableRenderer extends Component {
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue (%(aggregatorName)s)', {
+ aggregatorName: t(this.props.aggregatorName),
+ })}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Translation Key</b></div>
<div id="fix">
The new translation key 'Subvalue (%(aggregatorName)s)' isn't in the translation files, so the UI will show the raw key instead of translated text for subtotal labels in pivot tables. Also, 'Subvalue' appears to be a typo for 'Subtotal'. Consider updating to 'Subtotal (%(aggregatorName)s)' like the Total label does, and ensure translations are added.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- {t('Subvalue (%(aggregatorName)s)', {
+ {t('Subtotal (%(aggregatorName)s)', {
@@ -936,3 +936,3 @@
- {t('Subvalue (%(aggregatorName)s)', {
+ {t('Subtotal (%(aggregatorName)s)', {
```
</div>
</details>
</div>
<small><i>Code Review Run #78dc73</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org