You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by Mallory Mooney <ma...@datadoghq.com> on 2018/11/02 16:34:20 UTC

Re: Request for a technical review

Hi everyone!

Just wanted to check-in to see if anyone has had the chance to take a look
at the draft and leave feedback. I'll be locking things down for this one
by Thursday of next week (Nov. 8), so there's some time left if you are
still working through it.

Have a great weekend!


On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney <ma...@datadoghq.com>
wrote:

> Hi all!
>
> Just wanted to give you an update. I am working to get things for this
> series wrapped up by the first week of November. Hopefully, that still
> gives everyone enough time to review and leave any feedback.
>
> Mallory
>
> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney <
> mallory.mooney@datadoghq.com> wrote:
>
>> Igal, it will be available publicly once published! I don't have an
>> official publish date yet but can share that when it becomes more concrete.
>>
>> And no PRs yet, Chris! It's still in the less cool GDoc stage of the
>> review process. :)
>>
>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org> wrote:
>>
>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
>>> > -----BEGIN PGP SIGNED MESSAGE-----
>>> > Hash: SHA256
>>> >
>>> > Mallory,
>>> >
>>> > On 10/12/18 13:23, Mallory Mooney wrote:
>>> >> I definitely appreciate everyone's willingness to help out!
>>> >>
>>> >> Here is the link to the GDoc:
>>> >>
>>> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI56_jgUhHgKczFE/edit?usp=sharing
>>> >>   Requesting access will still be needed, but I can grant that ASAP.
>>> >> I want to make sure I can attribute comments/suggestions to
>>> >> specific people, so I know who to thank, and who to follow up with
>>> >> if I need more clarification on a specific comment. Plus, it makes
>>> >> the IT department happy.
>>> > What, no GitHub PRs? ;)
>>>
>>> +1
>>>
>>> Is that going to be publicly available or is it a
>>> proprietary/private/commercial guide?
>>>
>>>
>>> Igal
>>>
>>> > - -chris
>>> >
>>> >> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz <
>>> >> chris@christopherschultz.net> wrote:
>>> >>
>>> >> Mark,
>>> >>
>>> >> On 10/10/18 6:00 PM, Mark Thomas wrote:
>>> >>>>> On 10/10/18 17:44, Mallory Mooney wrote:
>>> >>>>>> Hi all,
>>> >>>>>>
>>> >>>>>> I work for Datadog and am writing a guide about monitoring
>>> >>>>>> Tomcat (with or without Datadog). I'd love to get some
>>> >>>>>> feedback on the technical content. The project maintainers
>>> >>>>>> we reached out to recommended we post a request here.
>>> >>>>>>
>>> >>>>>> Would anyone be up for that? I can send the post link to
>>> >>>>>> someone directly.
>>> >>>>>>
>>> >>>>>> Appreciate your help and time!
>>> >>>>> Why not post the link here so the community can review the
>>> >>>>> document?
>>> >> +1
>>> >>
>>> >> There are many active community members who have an interest in
>>> >> monitoring. I'm sure you'll get lots of feedback.
>>> >>
>>> >> -chris
>>> >>> ---------------------------------------------------------------------
>>> >>>
>>> >>>
>>> > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>> >>> For additional commands, e-mail: users-help@tomcat.apache.org
>>> >>>
>>> >>>
>>> > -----BEGIN PGP SIGNATURE-----
>>> > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>>> >
>>> > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvA5qUACgkQHPApP6U8
>>> > pFjPDg/+NNmp2sdTXhuPD2cXJTtBGXGMoOLost629AJF2R5ddG79a685TDPENn6B
>>> > NVPInUppI6U42RgK9hYs6/3JNpHfMIDay8HC7zaErAiu4wBHowI3yFckofYJjUwD
>>> > Wcd2Wzo+eBDZrf2PgwqiBr41nw7kbkeEAQcGeBVce7RL/+3r8Fz7FG++P5Bguu7d
>>> > 0N9S7y6leD3AdkX1o+JC9hQ6/AP2F8rZc8sws57Q2dpeV5QtK+8Pf2qOQpd6fskB
>>> > RDK4RQ1f4nLeAZgQ6BibUkwOQj6Fw7jPBHKGIfm6m5MOHvROkRTMV+fX3oLAd/dG
>>> > 3S1aW/9x8WIbKgYShR9ixxca5QuBNICC/tt9/oTYNj3XPbZLalMmMgOZ/cJcNI+R
>>> > kORA8ehwACeP/hIb/aLztze5g8FqyPslM95VPH/TWqgQXxe7bgU5fb6nUF/aCa87
>>> > RC/JXjZ/TZwMM+9xw1PQGH8aXqVGoku4Q/cbwXa4ctqklMKdGzlYRjY7TVjrqyec
>>> > ZMdFMgDb76wmDg2luD2g7jUmJJVdAtYiGXIidt5k8EtvymK6Nq/sEwj1SApV5jhT
>>> > PGdViui42IeL6IIwKY9gbuihL4btm0we9OXeeVc6fn99lySvsI8JZVgIQJzNmWEX
>>> > axmPUrQZI9iIr8qC9tufcuZOxwHpgCjYPIpM4IsR4/vlZv2VpQc=
>>> > =j6GH
>>> > -----END PGP SIGNATURE-----
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>> > For additional commands, e-mail: users-help@tomcat.apache.org
>>> >
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>
>>>
>>
>> --
>> Mallory Mooney
>> Technical Content Writer
>>
>
>
> --
> Mallory Mooney
> Technical Content Writer
>


-- 
Mallory Mooney
Technical Content Writer

Re: Request for a technical review

Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mallory,

On 11/2/18 12:34, Mallory Mooney wrote:
> Hi everyone!
> 
> Just wanted to check-in to see if anyone has had the chance to take
> a look at the draft and leave feedback. I'll be locking things down
> for this one by Thursday of next week (Nov. 8), so there's some
> time left if you are still working through it.

In your section on connector/protocol types, you say that Tomcat
auto-switches between APR and NIO, and that the default is APR. That
is not true in Tomcat 8.5 and later, where NIO is the default unless
the APR Lifecycle Listener's "useAprConnector" attribute has been set
to true (the default value for that is false).

Your description about garbage collection seems to indicate that
Tomcat is somehow involved in GC algorithm selection. It's not: that's
entirely up to the JVM, of course.

Also, OOME's don't cause crashes. They cause confusion, since some
application's aren't resilient, and the JVM itself rarely goes down,
so some devs and admins think everything is okay. Generally, it's not
okay, but it might look okay. There are also OOMEs which are
completely benign and can be ignored. Knowing which is which comes
with experience.

- -chris

> On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney
> <ma...@datadoghq.com> wrote:
> 
>> Hi all!
>> 
>> Just wanted to give you an update. I am working to get things for
>> this series wrapped up by the first week of November. Hopefully,
>> that still gives everyone enough time to review and leave any
>> feedback.
>> 
>> Mallory
>> 
>> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney < 
>> mallory.mooney@datadoghq.com> wrote:
>> 
>>> Igal, it will be available publicly once published! I don't
>>> have an official publish date yet but can share that when it
>>> becomes more concrete.
>>> 
>>> And no PRs yet, Chris! It's still in the less cool GDoc stage
>>> of the review process. :)
>>> 
>>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org>
>>> wrote:
>>> 
>>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
> Mallory,
> 
> On 10/12/18 13:23, Mallory Mooney wrote:
>>>>>>> I definitely appreciate everyone's willingness to help
>>>>>>> out!
>>>>>>> 
>>>>>>> Here is the link to the GDoc:
>>>>>>> 
>>>>> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI5
6_jgUhHgKczFE/edit?usp=sharing
>>>>>>>
>>>>> 
Requesting access will still be needed, but I can grant that ASAP.
>>>>>>> I want to make sure I can attribute
>>>>>>> comments/suggestions to specific people, so I know who
>>>>>>> to thank, and who to follow up with if I need more
>>>>>>> clarification on a specific comment. Plus, it makes the
>>>>>>> IT department happy.
> What, no GitHub PRs? ;)
>>>>> 
>>>>> +1
>>>>> 
>>>>> Is that going to be publicly available or is it a 
>>>>> proprietary/private/commercial guide?
>>>>> 
>>>>> 
>>>>> Igal
>>>>> 
> -chris
> 
>>>>>>> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz < 
>>>>>>> chris@christopherschultz.net> wrote:
>>>>>>> 
>>>>>>> Mark,
>>>>>>> 
>>>>>>> On 10/10/18 6:00 PM, Mark Thomas wrote:
>>>>>>>>>> On 10/10/18 17:44, Mallory Mooney wrote:
>>>>>>>>>>> Hi all,
>>>>>>>>>>> 
>>>>>>>>>>> I work for Datadog and am writing a guide about
>>>>>>>>>>> monitoring Tomcat (with or without Datadog).
>>>>>>>>>>> I'd love to get some feedback on the technical
>>>>>>>>>>> content. The project maintainers we reached out
>>>>>>>>>>> to recommended we post a request here.
>>>>>>>>>>> 
>>>>>>>>>>> Would anyone be up for that? I can send the
>>>>>>>>>>> post link to someone directly.
>>>>>>>>>>> 
>>>>>>>>>>> Appreciate your help and time!
>>>>>>>>>> Why not post the link here so the community can
>>>>>>>>>> review the document?
>>>>>>> +1
>>>>>>> 
>>>>>>> There are many active community members who have an
>>>>>>> interest in monitoring. I'm sure you'll get lots of
>>>>>>> feedback.
>>>>>>> 
>>>>>>> -chris
>>>>>>>> ---------------------------------------------------------------
- ------
>>>>>>>>
>>>>>>>>
>
>>>>>>>> 
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>>>>> For additional commands, e-mail:
>>>>>>>> users-help@tomcat.apache.org
>>>>>>>> 
>>>>>>>> 
>>>>> 
>>>>> ------------------------------------------------------------------
- ---
>>>>>
>>>>> 
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail:
>>>>> users-help@tomcat.apache.org
>>>>> 
>>>> 
>>>> 
>>>> -------------------------------------------------------------------
- --
>>>>
>>>> 
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail:
>>>> users-help@tomcat.apache.org
>>>> 
>>>> 
>>> 
>>> -- Mallory Mooney Technical Content Writer
>>> 
>> 
>> 
>> -- Mallory Mooney Technical Content Writer
>> 
> 
> 
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvctPEACgkQHPApP6U8
pFi/vA/+LkINXqxpg73sWHH7kuAtLvQ007NUYyPln6htAYYWkKc4UI55N/JemxhB
VSUjSa/YmAP07rk2hGlDGMBnuW8rMsJePjD2z4UePCMS5sVmD2rVtemhCABy5ehn
Pow0LQXsmRHlYEDuelcMnaWHt709LQ+4cIJZ6dtAWf9wZBuGIHA23WPdddar/zG/
bKn4UffWADLrV7ij1mfMxJeP1ZYtQCbWJILO9q7UnbY33Scaur/LMuiY+RNeCX7/
r5kMnVi8Bpfi/pDnin/IXEx/2M9F/lS2wnpE0CUjZJfrhdu+mPeNlgSjZWVDA9Js
hK6ngtMft2bhM4h7wBgNiwAk4SejCGmKB+7z8mnnVaWs96HBwyxXsz86LSHFCrow
gZzbzHLlxQewLp9E2wY5oG/MMpG0KjE3isMKXhz+JB4NAiHxQ5KHU2VtOzk9qshf
hzPOCUI8qFvQvcvFZ01IOO1Q1ve+NIqJ2Mo8ysd631wTGJwJBDTakTbiYBUGqpzW
Uv1MybFmfrHr4LbwY00icndm7MB3Bm9ZSsjtjfTKSevO2dG6gK81k5i6YpIsACdG
uhOnF7lckHbCGeNqPSeCi5Je/0BQOLGYtgw4+SPJRC0c4/EvCJ9wOzvyn/yHI08d
Yzyv08tuhEKk9QBx5d0lB9w0uH8279dq5WhWASmbgku9/FYD2vg=
=cH4J
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: Request for a technical review

Posted by Mark Thomas <ma...@apache.org>.
On 13/12/2018 08:33, Jäkel, Guido wrote:
> Dear Mallory and Mark,
> 
>   then I'm the one of the rare who use an "unusual" setups for more than 10 years :) . On a staged farm of about 3*10 Tomcat's we run a whole bunch of "webapps"; most of them in at least two instances for failover.
> 
>   But I never configured more than one Service and one Engine: There is only one Service , with an AJP Connector for the reverse proxy (Apache httpd + Jakarta) and a http Connector for service purposes. Inside, there is one Engine and inside this, there are a bundle of Hosts for each domain needed for the applications and inside each hosts (using an individual appBase for each domain), the deployments spawn contexts for each application running. Among this hosts, there's also a "localhost" taking the admin applications. This one is addressed via the http Connector.

What is unusual about that? Seems fairly standard virtual hosting to me.

Mark

> 
> Guido
> 
>> -----Original Message-----
>> From: Mark Thomas [mailto:markt@apache.org]
>> Sent: Wednesday, December 12, 2018 3:26 PM
>> To: users@tomcat.apache.org
>> Subject: Re: Request for a technical review
>> The first architecture diagram:
>> - doesn't show any hosts
>> - incorrectly classes a "Service" as a "webapp" (a context is a webapp)
>> - shows the unusual setup of multiple services
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: Request for a technical review

Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Guido,

On 12/13/18 03:33, Jäkel, Guido wrote:
> Dear Mallory and Mark,
> 
> then I'm the one of the rare who use an "unusual" setups for more
> than 10 years :) . On a staged farm of about 3*10 Tomcat's we run a
> whole bunch of "webapps"; most of them in at least two instances
> for failover.

When Mark says "unusual setup of multiple services", I think he meant
"unusual setup of multiple <Service>s". There's a big difference in
the reading of one versus another.

> But I never configured more than one Service and one Engine

Right: just like everyone else, a single <Service> is sufficient for you
.

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwUKPEACgkQHPApP6U8
pFjsQxAAiM38DefvgGsl7jDedbl9JN7kPLAsa8S11jpL+IVSZgGcNjLkM1SO1fEY
LwuXHkDf+uITqx9gjObzX33MQ8bzgIkfsCwWEKWrQqvDNJ0LiVMn6QC0z8q7LjFb
loEywHvJ/fsRAbFdEr6EYgZZFlayU0MtiyjeKFs7sB5BOfbWFzQinCR80Z+Hem0y
3rZiWSOFqAWT/4dfy6AHZEh54Ir5vC/FWQNddh6perXAUopvptIyTTA83+5OnC1/
JQ8CWQnz/7MDO/WeO+28/3hfLr9iN2POMa6V4jZ9Od1XoaHafgWHOrpkM13BzAQI
zsJOA3HYJSjoZby+f582qnYsQ05rWBEfjOWJ+64y5dw9pfH9y32xau5CULa3SY34
Vb3kTo71kjirtS3xMxecHpgQnIq3qfKqmbxz2By9IWD6KyhgXBpu4ALkxUMTh1is
pmq4Px/l+YFsUocQ1u3L71Lmy7wrRpjjKaaiE88pkZyz9Qd5xQrqmdlsOQ2Js00f
AwLhWridvoB8vcvg70znm4AZNQM5jxJ9JCETsY4rYg7eKcI9sjcpbCvF+lefeoUY
i8/5sesXzKzQh3CXi7hRfLI+jFbLotiwDDKsTRnl+hMlbCPsLNrusud5Ri7ujj3d
xzX0nYhWbgqmA7VCnPqzjdOrtXfXzIz3mjoVvXG9JrGYAaOwf8s=
=6SGJ
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


RE: Request for a technical review

Posted by Jäkel, Guido <G....@dnb.de>.
Dear Mallory and Mark,

  then I'm the one of the rare who use an "unusual" setups for more than 10 years :) . On a staged farm of about 3*10 Tomcat's we run a whole bunch of "webapps"; most of them in at least two instances for failover.

  But I never configured more than one Service and one Engine: There is only one Service , with an AJP Connector for the reverse proxy (Apache httpd + Jakarta) and a http Connector for service purposes. Inside, there is one Engine and inside this, there are a bundle of Hosts for each domain needed for the applications and inside each hosts (using an individual appBase for each domain), the deployments spawn contexts for each application running. Among this hosts, there's also a "localhost" taking the admin applications. This one is addressed via the http Connector.

Guido

>-----Original Message-----
>From: Mark Thomas [mailto:markt@apache.org]
>Sent: Wednesday, December 12, 2018 3:26 PM
>To: users@tomcat.apache.org
>Subject: Re: Request for a technical review
>The first architecture diagram:
> - doesn't show any hosts
> - incorrectly classes a "Service" as a "webapp" (a context is a webapp)
> - shows the unusual setup of multiple services

Re: Request for a technical review

Posted by Mallory Mooney <ma...@datadoghq.com>.
Appreciate your feedback, Mark. I'll get it incorporated ASAP.

On Wed, Dec 12, 2018 at 8:26 AM Mark Thomas <ma...@apache.org> wrote:

> On 11/12/2018 19:20, Mallory Mooney wrote:
> > Hi all!
> >
> > It's been a long time coming, so I wanted to resurrect this thread one
> more
> > time to share the now published post. You can find it at
> > https://www.datadoghq.com/blog/tomcat-architecture-and-performance/.
>
> Now I can see the document without having to authenticate...
>
> The first architecture diagram:
>  - doesn't show any hosts
>  - incorrectly classes a "Service" as a "webapp" (a context is a webapp)
>  - shows the unusual setup of multiple services
>
> "Server" and "Service" are not peers. "Service" must be nested inside
> "Server".
>
> The following sentence is misleading at best:
> "The engine returns the appropriate response (e.g., JSP page, servlet)
> to the client based on the Host request-header field in the request."
>
> AJP allows integration with multiple reverse proxies. Not just httpd.
>
> It is extremely debatable whether using httpd for static content is more
> efficient.
>
> The description of the differences between APR/native and NIO[2] is
> wrong. All the connectors support non-blocking. When the switch between
> non-blocking and simulated blocking happens depends on whether there is
> an active request and the APIs used by the application.
>
> Note there can be more than one acceptor thread.
>
> The default for minSpareThreads does not agree with the Tomcat docs - it
> should be 10. It is 25 for an Executor.
>
> Using an Executor doesn't "evenly distribute threads across multiple
> connectors". By providing a single thread pool for multiple connectors
> threads can be used more efficiently. That means that - rather than an
> even distribution - a connector could be starved of threads during a
> period of heavy load if all the threads are allocated to a different
> connector (unlikely but possible). Any admin/monitoring services exposed
> via HTTP probably needs to have a dedicated thread pool to ensure it is
> always available.
>
> It would be worth including an upfront warning of about the (lack of)
> security in JMX. There is almost no granularity in the access controls
> and brute force are easy to mount but hard to detect. The Tomcat
> security guide discusses this in more detail.
>
> maxTime isn't a "cumulative count". It is the longest time for any
> single request to complete.
>
> Tomcat won't return 503s if it runs out of threads. It will simply drop
> the connection. If a reverse proxy is being used, it will probably
> return a 503 in those circumstances.
>
> Nothing jumped out at me while I was reading the metrics sections. I'd
> probably add a note that an OOME means you need to restart the server.
> An OOME might be recoverable or might not. As a user there is no way to
> tell. The only safe thing to do is to restart.
>
> Mark
>
> >
> > I hope everyone has a great week!
> > Mallory
> >
> >
> >
> > On Sat, Nov 3, 2018 at 4:28 AM Mark Thomas <ma...@apache.org> wrote:
> >
> >> On 02/11/2018 16:34, Mallory Mooney wrote:
> >>> Hi everyone!
> >>>
> >>> Just wanted to check-in to see if anyone has had the chance to take a
> >> look
> >>> at the draft and leave feedback. I'll be locking things down for this
> one
> >>> by Thursday of next week (Nov. 8), so there's some time left if you are
> >>> still working through it.
> >>
> >> Note I suspect a number of folks aren't even looking at it because it is
> >> behind an authentication-wall (regardless of how willingly / speedily
> >> access is granted on request).
> >>
> >> Mark
> >>
> >>
> >>>
> >>> Have a great weekend!
> >>>
> >>>
> >>> On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney <
> >> mallory.mooney@datadoghq.com>
> >>> wrote:
> >>>
> >>>> Hi all!
> >>>>
> >>>> Just wanted to give you an update. I am working to get things for this
> >>>> series wrapped up by the first week of November. Hopefully, that still
> >>>> gives everyone enough time to review and leave any feedback.
> >>>>
> >>>> Mallory
> >>>>
> >>>> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney <
> >>>> mallory.mooney@datadoghq.com> wrote:
> >>>>
> >>>>> Igal, it will be available publicly once published! I don't have an
> >>>>> official publish date yet but can share that when it becomes more
> >> concrete.
> >>>>>
> >>>>> And no PRs yet, Chris! It's still in the less cool GDoc stage of the
> >>>>> review process. :)
> >>>>>
> >>>>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org>
> wrote:
> >>>>>
> >>>>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
> >>> Mallory,
> >>>
> >>> On 10/12/18 13:23, Mallory Mooney wrote:
> >>>>>>>>> I definitely appreciate everyone's willingness to help out!
> >>>>>>>>>
> >>>>>>>>> Here is the link to the GDoc:
> >>>>>>>>>
> >>>>>>>
> >>
> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI56_jgUhHgKczFE/edit?usp=sharing
> >>>>>>>>>   Requesting access will still be needed, but I can grant that
> >> ASAP.
> >>>>>>>>> I want to make sure I can attribute comments/suggestions to
> >>>>>>>>> specific people, so I know who to thank, and who to follow up
> with
> >>>>>>>>> if I need more clarification on a specific comment. Plus, it
> makes
> >>>>>>>>> the IT department happy.
> >>> What, no GitHub PRs? ;)
> >>>>>>>
> >>>>>>> +1
> >>>>>>>
> >>>>>>> Is that going to be publicly available or is it a
> >>>>>>> proprietary/private/commercial guide?
> >>>>>>>
> >>>>>>>
> >>>>>>> Igal
> >>>>>>>
> >>> -chris
> >>>
> >>>>>>>>> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz <
> >>>>>>>>> chris@christopherschultz.net> wrote:
> >>>>>>>>>
> >>>>>>>>> Mark,
> >>>>>>>>>
> >>>>>>>>> On 10/10/18 6:00 PM, Mark Thomas wrote:
> >>>>>>>>>>>> On 10/10/18 17:44, Mallory Mooney wrote:
> >>>>>>>>>>>>> Hi all,
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I work for Datadog and am writing a guide about monitoring
> >>>>>>>>>>>>> Tomcat (with or without Datadog). I'd love to get some
> >>>>>>>>>>>>> feedback on the technical content. The project maintainers
> >>>>>>>>>>>>> we reached out to recommended we post a request here.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Would anyone be up for that? I can send the post link to
> >>>>>>>>>>>>> someone directly.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Appreciate your help and time!
> >>>>>>>>>>>> Why not post the link here so the community can review the
> >>>>>>>>>>>> document?
> >>>>>>>>> +1
> >>>>>>>>>
> >>>>>>>>> There are many active community members who have an interest in
> >>>>>>>>> monitoring. I'm sure you'll get lots of feedback.
> >>>>>>>>>
> >>>>>>>>> -chris
> >>>>>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>>>>>
> >>>>>>>>>>
> >>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>>>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>
> >>>>>>>
> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>>>
> >>>>>>
> >>>>>
> >>>>> --
> >>>>> Mallory Mooney
> >>>>> Technical Content Writer
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> Mallory Mooney
> >>>> Technical Content Writer
> >>>>
> >>>
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: users-help@tomcat.apache.org
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
>

-- 
Mallory Mooney
Technical Content Writer

Re: Request for a technical review

Posted by Mark Thomas <ma...@apache.org>.
On 11/12/2018 19:20, Mallory Mooney wrote:
> Hi all!
> 
> It's been a long time coming, so I wanted to resurrect this thread one more
> time to share the now published post. You can find it at
> https://www.datadoghq.com/blog/tomcat-architecture-and-performance/.

Now I can see the document without having to authenticate...

The first architecture diagram:
 - doesn't show any hosts
 - incorrectly classes a "Service" as a "webapp" (a context is a webapp)
 - shows the unusual setup of multiple services

"Server" and "Service" are not peers. "Service" must be nested inside
"Server".

The following sentence is misleading at best:
"The engine returns the appropriate response (e.g., JSP page, servlet)
to the client based on the Host request-header field in the request."

AJP allows integration with multiple reverse proxies. Not just httpd.

It is extremely debatable whether using httpd for static content is more
efficient.

The description of the differences between APR/native and NIO[2] is
wrong. All the connectors support non-blocking. When the switch between
non-blocking and simulated blocking happens depends on whether there is
an active request and the APIs used by the application.

Note there can be more than one acceptor thread.

The default for minSpareThreads does not agree with the Tomcat docs - it
should be 10. It is 25 for an Executor.

Using an Executor doesn't "evenly distribute threads across multiple
connectors". By providing a single thread pool for multiple connectors
threads can be used more efficiently. That means that - rather than an
even distribution - a connector could be starved of threads during a
period of heavy load if all the threads are allocated to a different
connector (unlikely but possible). Any admin/monitoring services exposed
via HTTP probably needs to have a dedicated thread pool to ensure it is
always available.

It would be worth including an upfront warning of about the (lack of)
security in JMX. There is almost no granularity in the access controls
and brute force are easy to mount but hard to detect. The Tomcat
security guide discusses this in more detail.

maxTime isn't a "cumulative count". It is the longest time for any
single request to complete.

Tomcat won't return 503s if it runs out of threads. It will simply drop
the connection. If a reverse proxy is being used, it will probably
return a 503 in those circumstances.

Nothing jumped out at me while I was reading the metrics sections. I'd
probably add a note that an OOME means you need to restart the server.
An OOME might be recoverable or might not. As a user there is no way to
tell. The only safe thing to do is to restart.

Mark

> 
> I hope everyone has a great week!
> Mallory
> 
> 
> 
> On Sat, Nov 3, 2018 at 4:28 AM Mark Thomas <ma...@apache.org> wrote:
> 
>> On 02/11/2018 16:34, Mallory Mooney wrote:
>>> Hi everyone!
>>>
>>> Just wanted to check-in to see if anyone has had the chance to take a
>> look
>>> at the draft and leave feedback. I'll be locking things down for this one
>>> by Thursday of next week (Nov. 8), so there's some time left if you are
>>> still working through it.
>>
>> Note I suspect a number of folks aren't even looking at it because it is
>> behind an authentication-wall (regardless of how willingly / speedily
>> access is granted on request).
>>
>> Mark
>>
>>
>>>
>>> Have a great weekend!
>>>
>>>
>>> On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney <
>> mallory.mooney@datadoghq.com>
>>> wrote:
>>>
>>>> Hi all!
>>>>
>>>> Just wanted to give you an update. I am working to get things for this
>>>> series wrapped up by the first week of November. Hopefully, that still
>>>> gives everyone enough time to review and leave any feedback.
>>>>
>>>> Mallory
>>>>
>>>> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney <
>>>> mallory.mooney@datadoghq.com> wrote:
>>>>
>>>>> Igal, it will be available publicly once published! I don't have an
>>>>> official publish date yet but can share that when it becomes more
>> concrete.
>>>>>
>>>>> And no PRs yet, Chris! It's still in the less cool GDoc stage of the
>>>>> review process. :)
>>>>>
>>>>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org> wrote:
>>>>>
>>>>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
>>> Mallory,
>>>
>>> On 10/12/18 13:23, Mallory Mooney wrote:
>>>>>>>>> I definitely appreciate everyone's willingness to help out!
>>>>>>>>>
>>>>>>>>> Here is the link to the GDoc:
>>>>>>>>>
>>>>>>>
>> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI56_jgUhHgKczFE/edit?usp=sharing
>>>>>>>>>   Requesting access will still be needed, but I can grant that
>> ASAP.
>>>>>>>>> I want to make sure I can attribute comments/suggestions to
>>>>>>>>> specific people, so I know who to thank, and who to follow up with
>>>>>>>>> if I need more clarification on a specific comment. Plus, it makes
>>>>>>>>> the IT department happy.
>>> What, no GitHub PRs? ;)
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> Is that going to be publicly available or is it a
>>>>>>> proprietary/private/commercial guide?
>>>>>>>
>>>>>>>
>>>>>>> Igal
>>>>>>>
>>> -chris
>>>
>>>>>>>>> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz <
>>>>>>>>> chris@christopherschultz.net> wrote:
>>>>>>>>>
>>>>>>>>> Mark,
>>>>>>>>>
>>>>>>>>> On 10/10/18 6:00 PM, Mark Thomas wrote:
>>>>>>>>>>>> On 10/10/18 17:44, Mallory Mooney wrote:
>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I work for Datadog and am writing a guide about monitoring
>>>>>>>>>>>>> Tomcat (with or without Datadog). I'd love to get some
>>>>>>>>>>>>> feedback on the technical content. The project maintainers
>>>>>>>>>>>>> we reached out to recommended we post a request here.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Would anyone be up for that? I can send the post link to
>>>>>>>>>>>>> someone directly.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Appreciate your help and time!
>>>>>>>>>>>> Why not post the link here so the community can review the
>>>>>>>>>>>> document?
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>> There are many active community members who have an interest in
>>>>>>>>> monitoring. I'm sure you'll get lots of feedback.
>>>>>>>>>
>>>>>>>>> -chris
>>>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>>
>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Mallory Mooney
>>>>> Technical Content Writer
>>>>>
>>>>
>>>>
>>>> --
>>>> Mallory Mooney
>>>> Technical Content Writer
>>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: users-help@tomcat.apache.org
>>
>>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: Request for a technical review

Posted by Mallory Mooney <ma...@datadoghq.com>.
Hi all!

It's been a long time coming, so I wanted to resurrect this thread one more
time to share the now published post. You can find it at
https://www.datadoghq.com/blog/tomcat-architecture-and-performance/.

I hope everyone has a great week!
Mallory



On Sat, Nov 3, 2018 at 4:28 AM Mark Thomas <ma...@apache.org> wrote:

> On 02/11/2018 16:34, Mallory Mooney wrote:
> > Hi everyone!
> >
> > Just wanted to check-in to see if anyone has had the chance to take a
> look
> > at the draft and leave feedback. I'll be locking things down for this one
> > by Thursday of next week (Nov. 8), so there's some time left if you are
> > still working through it.
>
> Note I suspect a number of folks aren't even looking at it because it is
> behind an authentication-wall (regardless of how willingly / speedily
> access is granted on request).
>
> Mark
>
>
> >
> > Have a great weekend!
> >
> >
> > On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney <
> mallory.mooney@datadoghq.com>
> > wrote:
> >
> >> Hi all!
> >>
> >> Just wanted to give you an update. I am working to get things for this
> >> series wrapped up by the first week of November. Hopefully, that still
> >> gives everyone enough time to review and leave any feedback.
> >>
> >> Mallory
> >>
> >> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney <
> >> mallory.mooney@datadoghq.com> wrote:
> >>
> >>> Igal, it will be available publicly once published! I don't have an
> >>> official publish date yet but can share that when it becomes more
> concrete.
> >>>
> >>> And no PRs yet, Chris! It's still in the less cool GDoc stage of the
> >>> review process. :)
> >>>
> >>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org> wrote:
> >>>
> >>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
> > Mallory,
> >
> > On 10/12/18 13:23, Mallory Mooney wrote:
> >>>>>>> I definitely appreciate everyone's willingness to help out!
> >>>>>>>
> >>>>>>> Here is the link to the GDoc:
> >>>>>>>
> >>>>>
> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI56_jgUhHgKczFE/edit?usp=sharing
> >>>>>>>   Requesting access will still be needed, but I can grant that
> ASAP.
> >>>>>>> I want to make sure I can attribute comments/suggestions to
> >>>>>>> specific people, so I know who to thank, and who to follow up with
> >>>>>>> if I need more clarification on a specific comment. Plus, it makes
> >>>>>>> the IT department happy.
> > What, no GitHub PRs? ;)
> >>>>>
> >>>>> +1
> >>>>>
> >>>>> Is that going to be publicly available or is it a
> >>>>> proprietary/private/commercial guide?
> >>>>>
> >>>>>
> >>>>> Igal
> >>>>>
> > -chris
> >
> >>>>>>> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz <
> >>>>>>> chris@christopherschultz.net> wrote:
> >>>>>>>
> >>>>>>> Mark,
> >>>>>>>
> >>>>>>> On 10/10/18 6:00 PM, Mark Thomas wrote:
> >>>>>>>>>> On 10/10/18 17:44, Mallory Mooney wrote:
> >>>>>>>>>>> Hi all,
> >>>>>>>>>>>
> >>>>>>>>>>> I work for Datadog and am writing a guide about monitoring
> >>>>>>>>>>> Tomcat (with or without Datadog). I'd love to get some
> >>>>>>>>>>> feedback on the technical content. The project maintainers
> >>>>>>>>>>> we reached out to recommended we post a request here.
> >>>>>>>>>>>
> >>>>>>>>>>> Would anyone be up for that? I can send the post link to
> >>>>>>>>>>> someone directly.
> >>>>>>>>>>>
> >>>>>>>>>>> Appreciate your help and time!
> >>>>>>>>>> Why not post the link here so the community can review the
> >>>>>>>>>> document?
> >>>>>>> +1
> >>>>>>>
> >>>>>>> There are many active community members who have an interest in
> >>>>>>> monitoring. I'm sure you'll get lots of feedback.
> >>>>>>>
> >>>>>>> -chris
> >>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>
> >>>>>>>>
> > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> >>>> For additional commands, e-mail: users-help@tomcat.apache.org
> >>>>
> >>>>
> >>>
> >>> --
> >>> Mallory Mooney
> >>> Technical Content Writer
> >>>
> >>
> >>
> >> --
> >> Mallory Mooney
> >> Technical Content Writer
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
>

-- 
Mallory Mooney
Technical Content Writer

Re: Request for a technical review

Posted by Mark Thomas <ma...@apache.org>.
On 02/11/2018 16:34, Mallory Mooney wrote:
> Hi everyone!
> 
> Just wanted to check-in to see if anyone has had the chance to take a look
> at the draft and leave feedback. I'll be locking things down for this one
> by Thursday of next week (Nov. 8), so there's some time left if you are
> still working through it.

Note I suspect a number of folks aren't even looking at it because it is
behind an authentication-wall (regardless of how willingly / speedily
access is granted on request).

Mark


> 
> Have a great weekend!
> 
> 
> On Fri, Oct 19, 2018 at 7:52 AM Mallory Mooney <ma...@datadoghq.com>
> wrote:
> 
>> Hi all!
>>
>> Just wanted to give you an update. I am working to get things for this
>> series wrapped up by the first week of November. Hopefully, that still
>> gives everyone enough time to review and leave any feedback.
>>
>> Mallory
>>
>> On Fri, Oct 12, 2018 at 3:37 PM Mallory Mooney <
>> mallory.mooney@datadoghq.com> wrote:
>>
>>> Igal, it will be available publicly once published! I don't have an
>>> official publish date yet but can share that when it becomes more concrete.
>>>
>>> And no PRs yet, Chris! It's still in the less cool GDoc stage of the
>>> review process. :)
>>>
>>> On Fri, Oct 12, 2018 at 1:36 PM Igal Sapir <is...@apache.org> wrote:
>>>
>>>> On 10/12/2018 11:23 AM, Christopher Schultz wrote:
> Mallory,
> 
> On 10/12/18 13:23, Mallory Mooney wrote:
>>>>>>> I definitely appreciate everyone's willingness to help out!
>>>>>>>
>>>>>>> Here is the link to the GDoc:
>>>>>>>
>>>>> https://docs.google.com/document/d/1fudlXj055nnPd-1lUoAXIS2ge8qNI56_jgUhHgKczFE/edit?usp=sharing
>>>>>>>   Requesting access will still be needed, but I can grant that ASAP.
>>>>>>> I want to make sure I can attribute comments/suggestions to
>>>>>>> specific people, so I know who to thank, and who to follow up with
>>>>>>> if I need more clarification on a specific comment. Plus, it makes
>>>>>>> the IT department happy.
> What, no GitHub PRs? ;)
>>>>>
>>>>> +1
>>>>>
>>>>> Is that going to be publicly available or is it a
>>>>> proprietary/private/commercial guide?
>>>>>
>>>>>
>>>>> Igal
>>>>>
> -chris
> 
>>>>>>> On Thu, Oct 11, 2018 at 9:53 AM Christopher Schultz <
>>>>>>> chris@christopherschultz.net> wrote:
>>>>>>>
>>>>>>> Mark,
>>>>>>>
>>>>>>> On 10/10/18 6:00 PM, Mark Thomas wrote:
>>>>>>>>>> On 10/10/18 17:44, Mallory Mooney wrote:
>>>>>>>>>>> Hi all,
>>>>>>>>>>>
>>>>>>>>>>> I work for Datadog and am writing a guide about monitoring
>>>>>>>>>>> Tomcat (with or without Datadog). I'd love to get some
>>>>>>>>>>> feedback on the technical content. The project maintainers
>>>>>>>>>>> we reached out to recommended we post a request here.
>>>>>>>>>>>
>>>>>>>>>>> Would anyone be up for that? I can send the post link to
>>>>>>>>>>> someone directly.
>>>>>>>>>>>
>>>>>>>>>>> Appreciate your help and time!
>>>>>>>>>> Why not post the link here so the community can review the
>>>>>>>>>> document?
>>>>>>> +1
>>>>>>>
>>>>>>> There are many active community members who have an interest in
>>>>>>> monitoring. I'm sure you'll get lots of feedback.
>>>>>>>
>>>>>>> -chris
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>>>>>
>>>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: users-help@tomcat.apache.org
>>>>
>>>>
>>>
>>> --
>>> Mallory Mooney
>>> Technical Content Writer
>>>
>>
>>
>> --
>> Mallory Mooney
>> Technical Content Writer
>>
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org