You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Mubarak Seyed <se...@apple.com> on 2012/07/20 09:49:20 UTC

Review Request: Ganglia metrics plugin should filter MBean name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6060/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Ganglia metrics shows MBean name + metric name and it appears from ganglia UI that graph is not getting rendered properly. The fix is to filter the MBean name and prepend "flume" for ganglia context. Thanks.


This addresses bug FLUME-1386.
    https://issues.apache.org/jira/browse/FLUME-1386


Diffs
-----

  trunk/flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1363666 

Diff: https://reviews.apache.org/r/6060/diff/


Testing
-------

Yes.


Thanks,

Mubarak Seyed

Re: Review Request: Ganglia metrics plugin should filter MBean name

Posted by Hari Shreedharan <hs...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6060/#review9330
-----------------------------------------------------------

Ship it!


Already committed. Can you close? Thanks.

- Hari Shreedharan


On July 20, 2012, 7:49 a.m., Mubarak Seyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6060/
> -----------------------------------------------------------
> 
> (Updated July 20, 2012, 7:49 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Ganglia metrics shows MBean name + metric name and it appears from ganglia UI that graph is not getting rendered properly. The fix is to filter the MBean name and prepend "flume" for ganglia context. Thanks.
> 
> 
> This addresses bug FLUME-1386.
>     https://issues.apache.org/jira/browse/FLUME-1386
> 
> 
> Diffs
> -----
> 
>   trunk/flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1363666 
> 
> Diff: https://reviews.apache.org/r/6060/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Mubarak Seyed
> 
>