You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2008/06/16 20:07:45 UTC

[jira] Created: (PIG-269) Merge changes from trunk to "types" branch

Merge changes from trunk to "types" branch
------------------------------------------

                 Key: PIG-269
                 URL: https://issues.apache.org/jira/browse/PIG-269
             Project: Pig
          Issue Type: Sub-task
            Reporter: Pradeep Kamath
            Assignee: Alan Gates


A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: hadoop17.patch

Patch which addresses the following JIRAs with caveats listed below:
PIG-250: speculative execution is broken; 
PIG-198: Integration with hadoop 17

Caveats:
Files not patched:
src/org/apache/pig/backend/executionengine/PigSlicer.java - not present yet in types
src/org/apache/pig/backend/hadoop/executionengine/HExecutionEngine.java - changes depend on Config properties change
src/org/apache/pig/backend/hadoop/executionengine/mapreduceExec/PigMapReduce.java - this is present in ../impl/mapReduceLayer now and is different in content - depends on some other change going in first which will cause PigMapReduce to "implement" MapRunnable and Reducer (in the types branch it currently does not implement any interface)
 src/org/apache/pig/backend/hadoop/executionengine/mapreduceExec/PigCombine.java - not present in types

This patch also includes changes to build.xml (besides the change for hadoop17) to:
1) show deprecation warnings in default compiles
2) support to show all compilation  warnings if "-Dall.warnings=1" is supplied on cmdline

Before applying the patch, hadoop17.jar should be copied to the lib subdirectory. I couldn't figure a way to upload that as part of the patch (is that even possible?)

The 3 unit tests - TestEvalPipeline, TestFilterOpNumeric and TestStoreOld still fail after application of this patch but are unrelated to its contents.


> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: hadoop17.patch, merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: streaming_optimizations.patch

Attached Patch for load-stream-store optimizations

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

    Attachment: PIG-123.patch

Merged PIG-123: escape characters

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614561#action_12614561 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

patch for PIG-123 committed. Thanks Santhosh for help with it!

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616723#action_12616723 ] 

Santhosh Srinivasan commented on PIG-269:
-----------------------------------------

Comments on Pig-154 merge:

Major:

File: src/org/apache/pig/PigServer.java

I am not sure if we can use op = lp.getSingleLeafPlanOutputOp(); for split. It will probably result in an exception

{code}
+        LogicalOperator op = null;
         try {
             lp = (new LogicalPlanBuilder(pigContext).parse(scope, query,
                     aliases, opTable, aliasOp));
+            op = lp.getSingleLeafPlanOutputOp();
         } catch (ParseException e) {
             throw (IOException) new IOException(e.getMessage()).initCause(e);
         }
{code}

Minor:

File: test/org/apache/pig/test/TestLogicalPlanBuilder.java

PigContext has been moved to the global scope. Testers have to be careful about define statements that persist between queries.

{code}
+    PigContext pigContext = new PigContext(ExecType.LOCAL, new Properties());
{code}

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632043#action_12632043 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

PIG-342-151.patch commited. Thanks, Pradeep

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-342-151.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-176-170-235-330.patch

Patch for Memory management related issues fixed in trunk

Please review since I had to also fix some code (besides what was in the original patches) and also apply the changes from the original patches in different places (since the code had changed)  - most of the differences are for PIG-176

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614935#action_12614935 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed the PIG-111 patch. Thansk Pradeep for contributing.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617462#action_12617462 ] 

Santhosh Srinivasan commented on PIG-269:
-----------------------------------------

Our unit tests that contain split do not exercise the code path in PigServer.java

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622763#action_12622763 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

patch PIG-55-300_v2.patch committed. thanks pradeep

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: hadoop17_v2.patch

Attached new version of patch to make types branch work with hadoop17. The delta to the old patch is the use of hiddenFileFilter in PigInputFormat to filter out hadoop system files (files or directories starting with "_" or ".")

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631123#action_12631123 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

streaming_optimizations.patch committed. Thanks, Pradeep

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-55-300.patch

New revision of PIG-55 patch which includes PIG-300. Minor delta to earlier patch which includes the minor changes from PIG-300 and also a small change in PigInputFormat to include a static member for jobConf for use by loaders

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG-55-300.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614155#action_12614155 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

Committed path for PIG-129 and PIG-164. Thanks Pradeep for contributing this.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

    Attachment: PIG_154_merge.patch

This is patch to merge in PIG-154. Please, review

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614135#action_12614135 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed patch for PIG-118 and PIG-114.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: hadoop17_v3.patch

Attached new version of hadoop17 integration patch.
Delta with earlier version is changes in build.xml. In the earlier patch I had attempted to allow for all warnings to be captured in the compilation and the "unchecked cast" warnings were filtered out using the Concat ant Task after the javac task. However this had a problem in that when javac Task failed, Concat would not run and hence the actual errors would not be shown on the console. This version of the patch handles this by removing the Concat task and showing all compilation output on console. If -Dall.warnings is supplied on cmdline, *all* warnings (including unchecked cast) will now be shown. The default compilation (without -Dall.warnings) will show only "deprecation" warnings

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: merge_main_to_types_batch1.patch

 Attached is a batched patch which merges following patches from main trunk to types branch. I have updated http://wiki.apache.org/pig/PigTypesBranchIntegration to indicate that a patch is ready but needs to be committed for these issues. Once these are committed, the wiki can be updated (not sure if we also want to update these issues individually).

 

|| [http://issues.apache.org/jira/browse/PIG-68 PIG-68] || build.xml improvements; might already be in; otherwise trivial to fix ||
|| [http://issues.apache.org/jira/browse/PIG-124 PIG-124] || running 1 test at a time; might already be there; trivial otherwise ||
|| [http://issues.apache.org/jira/browse/PIG-127 PIG-127] || target descriptions; might already be in; otherwise a trivial change that can be done now ||
|| [http://issues.apache.org/jira/browse/PIG-13 PIG-13] || implement version; trivial change; can be applied now ||
|| [http://issues.apache.org/jira/browse/PIG-58 PIG-58] || parameter substitution; can be moved now  ||
|| [http://issues.apache.org/jira/browse/PIG-203 PIG-203] || pig parser hangs on input script bigger ~1kb; can be committed right now after (58) ||
|| [http://issues.apache.org/jira/browse/PIG-150 PIG-150] || similar to 149; can be committed now  ||
|| [http://issues.apache.org/jira/browse/PIG-149 PIG-149] || fix for doc target can be committed now ||
|| [http://issues.apache.org/jira/browse/PIG-218 PIG-218] || param sub broken with some commands; can be committed now right after (58) ||
|| [http://issues.apache.org/jira/browse/PIG-220 PIG-220] || incorrect variable definition in parameter substitution; can be committed now after (58) ||
|| [http://issues.apache.org/jira/browse/PIG-222 PIG-222] || param subst tests hardwire perl location; can be committed now right after (58) ||

The following issue involves only svn properties  do we need to merge at all since the change has already been made in main?
PIG-122 remove ?TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser; - involves only changing svn properties



> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-55-300_v2.patch

attached recreated patch with latest svn revision

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pi Song (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605935#action_12605935 ] 

Pi Song commented on PIG-269:
-----------------------------

All look good.

PIG-237 code was copied from type branch so don't need to merge

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: streaming_types_in_schema.patch

Attached patch to handles types in schema specifications in a stream statement

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617530#action_12617530 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed patch for PIG-154 with changes to address Santhosh's problem

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

        Fix Version/s: types_branch
    Affects Version/s: types_branch

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614442#action_12614442 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed path for hadoop 17 upgrade (PIG-198) also small change for integration of PIG-106

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pi Song (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609590#action_12609590 ] 

Pi Song commented on PIG-269:
-----------------------------

Looks good.
Ready to be committed.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

    Attachment: PIG-114-118-merge.patch

This is a trivial patch that merges in PIG-114 and PIG-118 from the trunk. Will commit it shortly unless I hear otherwise.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628465#action_12628465 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed streaming patch PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch. Thanks, Pradeep!

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch

Patch for merging streaming from trunk to types branch

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617356#action_12617356 ] 

Santhosh Srinivasan commented on PIG-269:
-----------------------------------------

There are no tests that use the split statement and execute the code path for the following code:

{code}
+        LogicalOperator op = null;
         try {
             lp = (new LogicalPlanBuilder(pigContext).parse(scope, query,
                     aliases, opTable, aliasOp));
+            op = lp.getSingleLeafPlanOutputOp();
         } catch (ParseException e) {
             throw (IOException) new IOException(e.getMessage()).initCause(e);
         }
{code}

I built the code and manually ran the following test which resulted in an exception:

{code}
grunt> a = load '/user/sms/data/student.data' as (name, age, gpa);
grunt> split a into x if age > 19, y if age <= 19;
java.lang.AssertionError: The plan has more than one leaf node
        at org.apache.pig.impl.logicalLayer.LogicalPlan.getSingleLeafPlanOutputOp(LogicalPlan.java:42)
        at org.apache.pig.PigServer.registerQuery(PigServer.java:250)
        at org.apache.pig.tools.grunt.GruntParser.processPig(GruntParser.java:425)
        at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:241)
        at org.apache.pig.tools.grunt.GruntParser.parseContOnError(GruntParser.java:92)
        at org.apache.pig.tools.grunt.Grunt.run(Grunt.java:58)
        at org.apache.pig.Main.main(Main.java:278)
{code}

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pi Song (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611533#action_12611533 ] 

Pi Song commented on PIG-269:
-----------------------------

PIG-256.patch checked-in. Thanks Pradeep.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-178-183.patch

Attached patch

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-269:
----------------------------------

    Assignee: Pradeep Kamath  (was: Alan Gates)

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-111-215-236-18-266-291.patch

Attached patch for PIG-111 (enabling configuration) and related patches as well integration of HOD0.4 and related patches.

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613725#action_12613725 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

I integrated a patch and ran the unit tests. I saw a couple of additional failures compared to the run without the patch. Pradeep is looking into them.



> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615848#action_12615848 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

committed PIG-176-170-235-330.patch. Thanks, Pradeep!

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614564#action_12614564 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

patch for PIG-172 committed

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617460#action_12617460 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

Ok, I will make the change. The question still remains - why unit tests did not catch this?

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-256.patch

Patch for PIG-256 to merge into "types" branch. I have marked the entry for PIG-256 in http://wiki.apache.org/pig/PigTypesBranchIntegration as "Patch submitted -needs to be committed". Please review and commit to types branch and mark the entry as "Yes"

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

    Attachment: PIG-172.patch

merge of PIG-172: detecting permission error 

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-55.patch

Patch for slicer related changes - PIG-55

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-256.patch, PIG-55.patch, PIG_154_merge.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629934#action_12629934 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

Committed streaming_types_in_schema.patch. Thanks, Pradeep

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-342-151.patch

Attached patch to merge PIG-342 and PIG-151

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-342-151.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-269:
-------------------------------

    Attachment: PIG-245-246

merge of piggybank from trunk

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-245-246, PIG-256.patch, PIG-342-151.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606429#action_12606429 ] 

Alan Gates commented on PIG-269:
--------------------------------

Checked in merge_main_to_types_batch1.patch 

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>         Attachments: merge_main_to_types_batch1.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-269:
-------------------------------

    Attachment: PIG-129-164.patch

Attached patch for PIG-129 and PIG-164 for merging into types branch

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Alan Gates
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, merge_main_to_types_batch1.patch, PIG-114-118-merge.patch, PIG-129-164.patch, PIG-256.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644101#action_12644101 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

attached patch that migrates UDF repository to types branch. will commit shortly unless I see any objections

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-245-246, PIG-256.patch, PIG-342-151.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-269) Merge changes from trunk to "types" branch

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631225#action_12631225 ] 

Olga Natkovich commented on PIG-269:
------------------------------------

PIG-178-183.patch committed. Thanks, Pradeep!

> Merge changes from trunk to "types" branch
> ------------------------------------------
>
>                 Key: PIG-269
>                 URL: https://issues.apache.org/jira/browse/PIG-269
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: hadoop17.patch, hadoop17_v2.patch, hadoop17_v3.patch, merge_main_to_types_batch1.patch, PIG-111-215-236-18-266-291.patch, PIG-114-118-merge.patch, PIG-123.patch, PIG-129-164.patch, PIG-172.patch, PIG-176-170-235-330.patch, PIG-178-183.patch, PIG-230-232-231-229-227-224-228-216-188-184-181-174-204.patch, PIG-256.patch, PIG-55-300.patch, PIG-55-300_v2.patch, PIG-55.patch, PIG_154_merge.patch, streaming_optimizations.patch, streaming_types_in_schema.patch
>
>
> A lot of changes have gone into trunk since the "types" branch was created. This jira issue is to track merging the changes from trunk to "types" branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.