[GitHub] [hive] pvary commented on a change in pull request #2817: HIVE-25740: Stop compaction heartbeating before abort/commit txn

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2817:
URL: https://github.com/apache/hive/pull/2817#discussion_r757717380



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -748,6 +736,7 @@ void wasSuccessful() {
      * @throws Exception
      */
     @Override public void close() throws Exception {
+      shutdownHeartbeater();

Review comment:
       We might just say to the heartbeater to ignore Exceptions at the shutdown phase 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org