You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 09:08:25 UTC

[GitHub] [airflow] eladkal commented on pull request #15609: Remove the `not-allow-trailing-slash` rule on S3_hook

eladkal commented on pull request #15609:
URL: https://github.com/apache/airflow/pull/15609#issuecomment-841118423


   tests are failing:
   ```
     _______________________ TestAwsS3Hook.test_parse_s3_url ________________________
     
     self = <tests.providers.amazon.aws.hooks.test_s3.TestAwsS3Hook object at 0x7f674ab4dda0>
     
         def test_parse_s3_url(self):
             parsed = S3Hook.parse_s3_url("s3://test/this/is/not/a-real-key.txt")
     >       assert parsed == ("test", "this/is/not/a-real-key.txt"), "Incorrect parsing of the s3 url"
     E       AssertionError: Incorrect parsing of the s3 url
     E       assert ('test', '/th...real-key.txt') == ('test', 'thi...real-key.txt')
     E         At index 1 diff: '/this/is/not/a-real-key.txt' != 'this/is/not/a-real-key.txt'
     E         Use -v to get the full diff
     
     tests/providers/amazon/aws/hooks/test_s3.py:70: AssertionError
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org