You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 11:45:54 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #2523: UnionBuilder Create Children With Capacity
tustvold opened a new issue, #2523:
URL: https://github.com/apache/arrow-rs/issues/2523
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
`UnionBuilder` is created with a capacity, but this is only used to pre-allocate its type_ids buffer. The child buffers are created with a capacity of 1.
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
We should save this capacity and pass it to `FieldData::new`. In the case of a sparse union, we should pass the maximum of the currently length and the capacity.
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kastolars commented on issue #2523: UnionBuilder Create Children With Capacity
Posted by GitBox <gi...@apache.org>.
kastolars commented on issue #2523:
URL: https://github.com/apache/arrow-rs/issues/2523#issuecomment-1224185031
I can give it a shot yeah, I'll try to get a PR out today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2523: UnionBuilder Create Children With Capacity
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2523:
URL: https://github.com/apache/arrow-rs/issues/2523#issuecomment-1223666234
No, would you like me to assign it to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kastolars commented on issue #2523: UnionBuilder Create Children With Capacity
Posted by GitBox <gi...@apache.org>.
kastolars commented on issue #2523:
URL: https://github.com/apache/arrow-rs/issues/2523#issuecomment-1221765269
Hi, has anyone started on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2523: UnionBuilder Create Children With Capacity
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2523: UnionBuilder Create Children With Capacity
URL: https://github.com/apache/arrow-rs/issues/2523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org