You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sudheesh Katkam <sk...@maprtech.com> on 2015/06/01 18:46:18 UTC
Re: Review Request 34829: DRILL-3190: Invalid FragmentState
transition from CANCELLATION_REQUESTED in QueryManager
> On May 29, 2015, 9:49 p.m., abdelhakim deneche wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java, line 69
> > <https://reviews.apache.org/r/34829/diff/1/?file=974693#file974693line69>
> >
> > Foreman state management is already split between the Foreman and the QueryManager. This will make the FragmentData handle part of that logic too!
> >
> > Shouldn't we move this to the QueryManager instead ? at least we would have one less class to check involved
Will make the change :)
- Sudheesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34829/#review85822
-----------------------------------------------------------
On May 29, 2015, 8:44 p.m., Sudheesh Katkam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34829/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 8:44 p.m.)
>
>
> Review request for drill, abdelhakim deneche, Chris Westin, and Jacques Nadeau.
>
>
> Bugs: DRILL-3190
> https://issues.apache.org/jira/browse/DRILL-3190
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3190: Check for transition from CANCELLATION_REQUESTED to non-terminal state in FragmentData
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentData.java ceb77f0
>
> Diff: https://reviews.apache.org/r/34829/diff/
>
>
> Testing
> -------
>
> Running unit and regresssion tests.
>
>
> Thanks,
>
> Sudheesh Katkam
>
>