You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/08 13:16:35 UTC
[GitHub] [flink] aljoscha opened a new pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
aljoscha opened a new pull request #13354:
URL: https://github.com/apache/flink/pull/13354
In FLINK-14850 we changed the `execute()` method to be basically
```
final JobClient jobClient = executeAsync(...);
return jobClient.getJobExecutionResult(userClassloader).get();
```
Unfortunately, this means that `execute()` now throws an `ExecutionException` instead of a `ProgramInvocationException` or `JobExecutionException` as before. The `ExecutionException` is wrapping the other exceptions that we were throwing before.
We didn't notice this in tests because most tests use `Test(Stream)Environment` which overrides the `execute()` method and so doesn't go through the PipelineExecutor logic or the normal code path of delegating to `executeAsync()`.
This change brings us back to the previous behaviour.
## Brief changelog
- unwrap exception in environments
- fix tests that were testing the wrong behaviour
## Verifying this change
- added a new integration test
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes**
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha edited a comment on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
aljoscha edited a comment on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-690150927
Thanks for the review! I'm thinking to also backport this to 1.10.x and 1.11.x but I'm torn because we would be flip-flopping in minor releases. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-688863968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6342",
"triggerID" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"triggerType" : "PUSH"
}, {
"hash" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 493d4e645176ab876b572fc7722ee04c423ecd41 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6342)
* 0b67901e6fb6811ffc7b8e85fef7dc20129f3184 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-688863968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6342",
"triggerID" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"triggerType" : "PUSH"
}, {
"hash" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6345",
"triggerID" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 493d4e645176ab876b572fc7722ee04c423ecd41 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6342)
* 0b67901e6fb6811ffc7b8e85fef7dc20129f3184 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6345)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13354:
URL: https://github.com/apache/flink/pull/13354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-690150927
Thanks for the review! I'm thinking to also backport this to 1.10.x and 1.11.x but I'm torn because we would be flip-flopping in minor releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-690118312
Good fix, thanks!
+1 to merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-688860093
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 493d4e645176ab876b572fc7722ee04c423ecd41 (Tue Sep 08 13:18:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-688863968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 493d4e645176ab876b572fc7722ee04c423ecd41 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13354: [FLINK-19135] Strip ExecutionException in (Stream)ExecutionEnvironment.execute()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13354:
URL: https://github.com/apache/flink/pull/13354#issuecomment-688863968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6342",
"triggerID" : "493d4e645176ab876b572fc7722ee04c423ecd41",
"triggerType" : "PUSH"
}, {
"hash" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6345",
"triggerID" : "0b67901e6fb6811ffc7b8e85fef7dc20129f3184",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b67901e6fb6811ffc7b8e85fef7dc20129f3184 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6345)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org