You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/08 02:04:12 UTC

[GitHub] [rocketmq] November22 opened a new issue #2786: ServerBootstrap 中的解码器org.apache.rocketmq.remoting.netty.NettyDecoder 为什么不用共享实例？

November22 opened a new issue #2786:
URL: https://github.com/apache/rocketmq/issues/2786


   RocketMQ 版本：4.7.1
   ![image](https://user-images.githubusercontent.com/26109828/113957048-20808a80-9851-11eb-804b-3dfc01cca088.png)
   org.apache.rocketmq.remoting.netty.NettyDecoder的内部属性FRAME_MAX_LENGTH 在程序启动后，是不可变的吧，这样NettyDecoder不持有任何状态。按照个人理解，这样就可以将NettyDecoder安全的用于多个Channel。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] felayman commented on issue #2786: ServerBootstrap 中的解码器org.apache.rocketmq.remoting.netty.NettyDecoder 为什么不用共享实例？

Posted by GitBox <gi...@apache.org>.
felayman commented on issue #2786:
URL: https://github.com/apache/rocketmq/issues/2786#issuecomment-816435913


   > 你少看了个继承吧，NettyDecorder继承自LengthFieldBasedFrameDecoder，在LengthFieldBasedFrameDecoder里是有很多不可复用的属性的
   
   目前看来就一个com.rocketmq.remoting.frameMaxLength是可能不复用的, 我理解NettyDecoder是可以复用于多个channel的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on issue #2786: ServerBootstrap 中的解码器org.apache.rocketmq.remoting.netty.NettyDecoder 为什么不用共享实例？

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2786:
URL: https://github.com/apache/rocketmq/issues/2786#issuecomment-816511933


   @felayman FYI，https://github.com/apache/rocketmq/pull/635/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] shenshaoming commented on issue #2786: ServerBootstrap 中的解码器org.apache.rocketmq.remoting.netty.NettyDecoder 为什么不用共享实例？

Posted by GitBox <gi...@apache.org>.
shenshaoming commented on issue #2786:
URL: https://github.com/apache/rocketmq/issues/2786#issuecomment-815491971


   你少看了个继承吧，NettyDecorder继承自LengthFieldBasedFrameDecoder，在LengthFieldBasedFrameDecoder里是有很多不可复用的属性的


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #2786: ServerBootstrap 中的解码器org.apache.rocketmq.remoting.netty.NettyDecoder 为什么不用共享实例？

Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #2786:
URL: https://github.com/apache/rocketmq/issues/2786


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org