You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sudheesh Katkam <sk...@maprtech.com> on 2015/04/13 20:35:42 UTC
Review Request 33138: DRILL-2766: Use PojoRecordReader for all system
tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33138/
-----------------------------------------------------------
Review request for drill and Venki Korukanti.
Repository: drill-git
Description
-------
[DRILL-2766](https://issues.apache.org/jira/browse/DRILL-2766): Removed SystemRecordReader and SystemRecords
+ Use PojoRecordReader with ThreadsIterator and MemoryIterator
+ Includes [DRILL-2670](https://issues.apache.org/jira/browse/DRILL-2670): Added a test case since [DRILL-2714](https://issues.apache.org/jira/browse/DRILL-2714) resolves this issue
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryIterator.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java 9cb001d
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecord.java 5bdb9b1
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecordReader.java 9f8d0d9
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 2c338ca
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableBatchCreator.java 0152b63
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java 13e0ff6
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsIterator.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsRecord.java b184880
exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java 4f4d29b
Diff: https://reviews.apache.org/r/33138/diff/
Testing
-------
Thanks,
Sudheesh Katkam
Re: Review Request 33138: DRILL-2766: Use PojoRecordReader for all
system tables
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33138/#review79921
-----------------------------------------------------------
Ship it!
Ship It!
- Jacques Nadeau
On April 13, 2015, 6:35 p.m., Sudheesh Katkam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33138/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 6:35 p.m.)
>
>
> Review request for drill and Venki Korukanti.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> [DRILL-2766](https://issues.apache.org/jira/browse/DRILL-2766): Removed SystemRecordReader and SystemRecords
> + Use PojoRecordReader with ThreadsIterator and MemoryIterator
> + Includes [DRILL-2670](https://issues.apache.org/jira/browse/DRILL-2670): Added a test case since [DRILL-2714](https://issues.apache.org/jira/browse/DRILL-2714) resolves this issue
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryIterator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java 9cb001d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecord.java 5bdb9b1
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecordReader.java 9f8d0d9
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java 2c338ca
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTableBatchCreator.java 0152b63
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTablePlugin.java 13e0ff6
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsIterator.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ThreadsRecord.java b184880
> exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java 4f4d29b
>
> Diff: https://reviews.apache.org/r/33138/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sudheesh Katkam
>
>