[GitHub] [spark] Kimahriman commented on pull request #41677: [WIP][SPARK-35564][SQL] Improve subexpression elimination

["Kimahriman (via GitHub)" <gi...@apache.org>]

Kimahriman commented on PR #41677:
URL: https://github.com/apache/spark/pull/41677#issuecomment-1601161174

   This hurts my brain thinking about probabilistic conditional evaluations, and I feel like the subexpression elimination logic is already overly complicated. If I wanted to just create subexpressions for anything that is definitely executed once and maybe executed one other time (regardless of how nested inside a CaseWhen or Coalesce operation), what do I even set the new setting to?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org