You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by samar kumar <sa...@gmail.com> on 2014/11/27 08:30:09 UTC
Review Request 28508: Falcon client methods should return objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
> On Dec. 12, 2014, 5:46 a.m., shwethags wrote:
> > Minor comment, will fix it and commit
Thanks!!
- samar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review64869
-----------------------------------------------------------
On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
> webapp/src/main/java/org/apache/falcon/Debug.java a650215
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review64869
-----------------------------------------------------------
Ship it!
Minor comment, will fix it and commit
client/src/main/java/org/apache/falcon/ResponseParserHelper.java
<https://reviews.apache.org/r/28508/#comment107663>
prefix method name with parse
- shwethags
On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
> webapp/src/main/java/org/apache/falcon/Debug.java a650215
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 12:48 p.m.)
Review request for Falcon.
Changes
-------
Changed to Entity from String
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
webapp/src/main/java/org/apache/falcon/Debug.java a650215
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 12:19 p.m.)
Review request for Falcon.
Changes
-------
changes after review comments
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar
Re: Review Request 28508: Falcon client methods should return objects
Posted by sh...@inmobi.com.
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 357
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line357>
> >
> > should return entity?
>
> samar kumar wrote:
> Defination entity is string itself
>
> return clientResponse.getEntity(String.class);
We can unmarshal from String and return Entity?
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review63221
-----------------------------------------------------------
On Dec. 4, 2014, 12:19 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:19 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 357
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line357>
> >
> > should return entity?
>
> samar kumar wrote:
> Defination entity is string itself
>
> return clientResponse.getEntity(String.class);
>
> shwethags wrote:
> We can unmarshal from String and return Entity?
Done
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 511
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line511>
> >
> > Fix these as well? Else, can you create a jira so that we don't lose track
>
> samar kumar wrote:
> return clientResponse.getEntity(String.class);
https://issues.apache.org/jira/browse/FALCON-941
- samar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review63221
-----------------------------------------------------------
On Dec. 11, 2014, 12:48 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 12:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
> webapp/src/main/java/org/apache/falcon/Debug.java a650215
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 357
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line357>
> >
> > should return entity?
Defination entity is string itself
return clientResponse.getEntity(String.class);
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 511
> > <https://reviews.apache.org/r/28508/diff/1/?file=777310#file777310line511>
> >
> > Fix these as well? Else, can you create a jira so that we don't lose track
return clientResponse.getEntity(String.class);
> On Nov. 27, 2014, 1:21 p.m., shwethags wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 442
> > <https://reviews.apache.org/r/28508/diff/1/?file=777309#file777309line442>
> >
> > Can we move these to toString() functions in the returned objects?
Moved it to a helper class
- samar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review63221
-----------------------------------------------------------
On Dec. 4, 2014, 12:19 p.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:19 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseParserHelper.java e69de29
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/#review63221
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/28508/#comment105393>
Can we move these to toString() functions in the returned objects?
client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/28508/#comment105394>
Can we change entity type to the corresponding enum?
client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/28508/#comment105395>
should return APIResult?
client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/28508/#comment105396>
should return entity?
client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/28508/#comment105398>
Fix these as well? Else, can you create a jira so that we don't lose track
client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/28508/#comment105399>
remove if not required
- shwethags
On Nov. 27, 2014, 7:30 a.m., samar kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28508/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 7:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-329
> https://issues.apache.org/jira/browse/FALCON-329
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon client methods should return objects
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
> client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
>
> Diff: https://reviews.apache.org/r/28508/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> samar kumar
>
>
Re: Review Request 28508: Falcon client methods should return objects
Posted by samar kumar <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28508/
-----------------------------------------------------------
(Updated Nov. 27, 2014, 7:30 a.m.)
Review request for Falcon.
Bugs: FALCON-329
https://issues.apache.org/jira/browse/FALCON-329
Repository: falcon-git
Description
-------
Falcon client methods should return objects
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f
client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed
Diff: https://reviews.apache.org/r/28508/diff/
Testing
-------
Thanks,
samar kumar