You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/09/16 11:53:42 UTC

DO NOT REPLY [Bug 45822] New: AFP Renderer: Minor border Painting Inconsistencies

https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

           Summary: AFP Renderer: Minor border Painting Inconsistencies
           Product: Fop
           Version: 0.95
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: bowditch_chris@hotmail.com


Created an attachment (id=22592)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22592)
Good Output

There are some minor problems with border painting in the AFP Renderer. These
are highlighted with the layout test case block_border-style. I have attached
good output from PDF and bad AFP output to illustrate the problem.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 45822] [PATCH] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Mehdi Houshmand <me...@gmail.com> ---
Amended and fixed in trunk@1403643.

-- 
You are receiving this mail because:
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

--- Comment #4 from Mehdi Houshmand <me...@gmail.com> 2010-10-14 07:26:36 EDT ---
I've had a look at this issue for dashed borders ONLY. There are some
inconsistencies between PS/PDF and AFP as to how these borders are drawn. There
are a couple issues here:
1) For dashed borders the "dash" and the white-space between are the same
length. This may seem trivial but doesn't quite look right, and isn't the same
behaviour as XEP. (This applies to PS/PDF and AFP.)
2) Since PS/PDF have almost identical code (duplicated) for this function (and
other methods), there really should be proper centralisation to prevent
duplication. Since both PDF and PS classes inherit from BorderPainter.java, if
we create a class to sandwich in between this inheritance stack it could
contain utility methods such as this. So it will be:
BorderPainter->AdobeBorderPainter then either PS/PDF-BorderPainter.


I'll make a slight change how both of them draw the borders (the change will
make them behave the same). Currently the ratio between dash-whitespace is 1:1,
this is implicitly a "magic number". I'll make a variable called
DASHED_BORDER_SPACE_RATIO that make this configurable, it will also ensure that
the output is the same between the various formats.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

--- Comment #6 from Mehdi Houshmand <me...@gmail.com> 2010-10-25 06:04:32 EDT ---
Created an attachment (id=26209)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26209)
proposed patch to fix bug# 45822

Changes made:
-Code style improvements (removed magic numbers etc...)
-Added JUnit tests for testing borders in PDF, PS and AFP
-Architectural improvements (made AFP rendering more like PS/PDF by removing
anonymous class)
-Made dashed borders more resemble a "dash" rather than a "dot"

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822





--- Comment #2 from Adrian Cumiskey <de...@cumiskey.com>  2008-09-25 01:57:02 PST ---
Hi Chris,

Could you please confirm that this is a problem on 0.95 (as noted in this bug
report) or with trunk or the Temp_AFPGOCAResources branch.

Adrian.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822





--- Comment #3 from Chris Bowditch <bo...@hotmail.com>  2008-09-25 02:20:52 PST ---
The problem exists in both trunk and Temp_AFPGOCAResources branch.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] [PATCH] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

Glenn Adams <gl...@skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
                 CC|                            |med1985@gmail.com
            Summary|AFP Renderer: Minor border  |[PATCH] AFP Renderer: Minor
                   |Painting Inconsistencies    |border Painting
                   |                            |Inconsistencies

--- Comment #8 from Glenn Adams <gl...@skynav.com> 2012-04-10 14:49:19 UTC ---
mehdi, do you plan to commit the attached patch? thanks, g.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822





--- Comment #1 from Chris Bowditch <bo...@hotmail.com>  2008-09-16 02:54:30 PST ---
Created an attachment (id=22593)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22593)
Bad Output


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

--- Comment #7 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:41:23 UTC ---
resetting P2 open bugs to P3 pending further review

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] [PATCH] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

--- Comment #9 from Glenn Adams <ga...@apache.org> 2012-04-11 03:20:28 UTC ---
increase priority for bugs with a patch

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 45822] AFP Renderer: Minor border Painting Inconsistencies

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45822

--- Comment #5 from Mehdi Houshmand <me...@gmail.com> 2010-10-14 08:30:34 EDT ---
After a little further investigation, it appears in this particular instance
the middle class "AdobeBorderPainter" is unnecessary since AFP also needs the
same function to define the length of the dash. So this will be put into
BorderPainter, so as all classes can inherit this method.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.