You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@infra.apache.org by "Zhe Zhang (JIRA)" <ji...@apache.org> on 2015/11/09 23:08:11 UTC

[jira] [Updated] (INFRA-10743) Support Gerrit integration for Hadoop

     [ https://issues.apache.org/jira/browse/INFRA-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhe Zhang updated INFRA-10743:
------------------------------
    Description: 
The Hadoop community is considering adding Gerrit as a review / commit
tool. Since this will require support from the Apache Infra team, it makes
more sense if multiple projects can benefit from the effort.

The main benefit of Gerrit over ReviewBoard is better integration with git
and Jenkins. A Gerrit review request is created through a simple "git push"
instead of manually creating and uploading a diff file. Conflicts detection
and rebase can be done on the review UI as well. When the programmed commit
criteria are met (e.g. a code review +1 and a Jenkins verification),
committing can also be done with a single button click, or even
automatically.

This also just augments instead of replacing the current review / commit
flow. Every task will still start as a JIRA. Review comments can be made on
both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
also be directly committed through git command line (Gerrit will recognize
a direct commit and close the review request as long as a simple git hook is installed 
(https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).

I have surveyed a few other projects, and have received positive feedback from HBase, HTrace, and Flume:

http://mail-archives.apache.org/mod_mbox/hbase-dev/201511.mbox/%3CCAAjoTXkeAR5xjNfWtEP87Y%3DPToaL7pyPeE2o1C4N5fh5d5s3Pw%40mail.gmail.com%3E

http://mail-archives.apache.org/mod_mbox/flume-dev/201511.mbox/%3CCAAjoTXmm0tMYyjbHs%3DgGsnCvt%3DWj1ZAb90JuiO2Ks5TORoJ3aA%40mail.gmail.com%3E

  was:
The Hadoop community is considering adding Gerrit as a review / commit
tool. Since this will require support from the Apache Infra team, it makes
more sense if multiple projects can benefit from the effort.

The main benefit of Gerrit over ReviewBoard is better integration with git
and Jenkins. A Gerrit review request is created through a simple "git push"
instead of manually creating and uploading a diff file. Conflicts detection
and rebase can be done on the review UI as well. When the programmed commit
criteria are met (e.g. a code review +1 and a Jenkins verification),
committing can also be done with a single button click, or even
automatically.

This also just augments instead of replacing the current review / commit
flow. Every task will still start as a JIRA. Review comments can be made on
both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
also be directly committed through git command line (Gerrit will recognize
a direct commit and close the review request as long as a simple git [hook | https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html]
is installed.

I have surveyed a few other projects, and have received positive feedback from HBase, HTrace, and Flume:

http://mail-archives.apache.org/mod_mbox/hbase-dev/201511.mbox/%3CCAAjoTXkeAR5xjNfWtEP87Y%3DPToaL7pyPeE2o1C4N5fh5d5s3Pw%40mail.gmail.com%3E

http://mail-archives.apache.org/mod_mbox/flume-dev/201511.mbox/%3CCAAjoTXmm0tMYyjbHs%3DgGsnCvt%3DWj1ZAb90JuiO2Ks5TORoJ3aA%40mail.gmail.com%3E


> Support Gerrit integration for Hadoop
> -------------------------------------
>
>                 Key: INFRA-10743
>                 URL: https://issues.apache.org/jira/browse/INFRA-10743
>             Project: Infrastructure
>          Issue Type: New Feature
>          Components: Jenkins
>            Reporter: Zhe Zhang
>
> The Hadoop community is considering adding Gerrit as a review / commit
> tool. Since this will require support from the Apache Infra team, it makes
> more sense if multiple projects can benefit from the effort.
> The main benefit of Gerrit over ReviewBoard is better integration with git
> and Jenkins. A Gerrit review request is created through a simple "git push"
> instead of manually creating and uploading a diff file. Conflicts detection
> and rebase can be done on the review UI as well. When the programmed commit
> criteria are met (e.g. a code review +1 and a Jenkins verification),
> committing can also be done with a single button click, or even
> automatically.
> This also just augments instead of replacing the current review / commit
> flow. Every task will still start as a JIRA. Review comments can be made on
> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> also be directly committed through git command line (Gerrit will recognize
> a direct commit and close the review request as long as a simple git hook is installed 
> (https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
> I have surveyed a few other projects, and have received positive feedback from HBase, HTrace, and Flume:
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201511.mbox/%3CCAAjoTXkeAR5xjNfWtEP87Y%3DPToaL7pyPeE2o1C4N5fh5d5s3Pw%40mail.gmail.com%3E
> http://mail-archives.apache.org/mod_mbox/flume-dev/201511.mbox/%3CCAAjoTXmm0tMYyjbHs%3DgGsnCvt%3DWj1ZAb90JuiO2Ks5TORoJ3aA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)