You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Bernt M. Johnsen (JIRA)" <ji...@apache.org> on 2006/11/09 10:31:37 UTC

[jira] Created: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
------------------------------------------------------------------------------------------------------

                 Key: DERBY-2065
                 URL: http://issues.apache.org/jira/browse/DERBY-2065
             Project: Derby
          Issue Type: Bug
            Reporter: Bernt M. Johnsen
            Priority: Minor


Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
----------- NetworkClient --------------
Message: Cannot close a connection while a transaction is still active.
SQLState: 25001
----------- Embedded --------------
Message: Invalid transaction state.
SQLState: 25000


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bernt M. Johnsen closed DERBY-2065.
-----------------------------------


> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: DERBY-2065-2.diff, DERBY-2065-2.stat, derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland reassigned DERBY-2065:
------------------------------------

    Assignee: Jørgen Løland

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536608 ] 

Knut Anders Hatlen commented on DERBY-2065:
-------------------------------------------

> SQLStateConstants.INVALID_TRANSACTION_STATE_NO_SUBCLASS are now
> unused, but I leave them declared since the constant 25000 is defined
> in the standard and may find some future use. 

Wouldn't it be better to remove the unused constants and their
messages? Keeping them in case one may find future use for them might
make sense when you look at a single case in isolation, but I think
keeping unused code in general makes the code harder to maintain. For
instance, it gets harder to translate Derby's messages to a new locale
since the translators waste time translating unused messages.

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Matrigali updated DERBY-2065:
----------------------------------

    Component/s: Network Server
                 Network Client

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Priority: Minor
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536601 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Committed patch derby-2065_1 at svn 587040. I added this note to the commit message:

As a result of this patch SQLState.LANG_INVALID_TRANSACTION_STATE and
the testing framework's equivalent
SQLStateConstants.INVALID_TRANSACTION_STATE_NO_SUBCLASS are now
unused, but I leave them declared since the constant 25000 is defined
in the standard and may find some future use.


> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2065:
---------------------------------

    Derby Info: [Patch Available, Release Note Needed]

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536652 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Thanks for the revision, Jørgen! I think the release notes look good now.
I will resolve the issue after a few days, to allow for any feedback on Knut's suggestion.


> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-2065:
---------------------------------

       Derby Info: [Existing Application Impact, Release Note Needed]  (was: [Release Note Needed, Existing Application Impact])
    Fix Version/s: 10.4.0.0

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: DERBY-2065-2.diff, DERBY-2065-2.stat, derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536591 ] 

Jørgen Løland commented on DERBY-2065:
--------------------------------------

Release note attached.

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536650 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Knut, I admit I was of two minds about leaving the message, for the
reason you quote.  I eventually decided to leave it, in part to save
translation(!) again later, But I am happy to remove it!

If nobody voices an opinion to keep it, I will remove it. Cleaning
away unused code is (almost?) always good ;)


> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536219 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Thanks, Jørgen! Patch looks good to me. Will commit it when I have run tests.

Would you be willing to produce a release note attachment as well (using the
template in tools/release/templates/releaseNote.html) ?

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2065:
---------------------------------

    Attachment: releaseNote.html

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2065:
---------------------------------

    Attachment: releaseNote.html

Good suggestions, Dag. Incorporated in the latest releaseNote.html

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik resolved DERBY-2065.
----------------------------------

    Resolution: Fixed
    Derby Info: [Existing Application Impact, Release Note Needed]  (was: [Release Note Needed, Existing Application Impact])

Committed patch DERBY-2065-2, which removes the unused error message at svn 590046.
Resolving.

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: DERBY-2065-2.diff, DERBY-2065-2.stat, derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536605 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

Thanks for the release note, Jørgen!
Looks good, some comments!

>Summary of Change
>Error code changed for embedded connection when a connection with an open transaction is closed.

The connection is not actually closed, so I would say "attempted
closed".

>Incompatibilities with Previous Release

I'd try to be a little more precise in this section, for example:

Embedded applications that are dependent on the error code
<it>ever</it> being "25000" could start failing.

Embedded applications that are dependent on the error code
<it>never</it> being "25001" could start failing.



> Rationale for Change
> Harmonize error codes raised by the client and embedded drivers. 

(suggest add) .. thereby also making the embedded driver compatible
with the SQL standard.



> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-2065:
---------------------------------

    Derby Info: [Existing Application Impact, Release Note Needed]  (was: [Release Note Needed, Patch Available])

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-2065:
---------------------------------

    Attachment: DERBY-2065-2.stat
                DERBY-2065-2.diff

Uploading a patch which removes the now unused error message,
running tests now.

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: DERBY-2065-2.diff, DERBY-2065-2.stat, derby-2065_1.diff, derby-2065_1.stat, releaseNote.html, releaseNote.html
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533116 ] 

Dag H. Wanvik commented on DERBY-2065:
--------------------------------------

See repro attached to DERBY-3114.
Also reproducing my comments attached to that JIRA (a duplicate of this):

The standard says about disconnect statement, section 17.3, general
rule 6: If any SQL-connection in L is active, then an exception
condition is raised: invalid transaction state - active SQL-transaction.

According to section 23.1 SQLSTATE (p.1075):

Subcondition: Active SQL transaction
subclass: 001

so, in this case, so it would appear that the use of 25001 is correct,
not 25000. I suggest we change embedded to use 25001 also, and release
note it, since it has application impact. 

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Priority: Minor
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2065) Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2065:
---------------------------------

    Attachment: derby-2065_1.diff
                derby-2065_1.stat

The attached patch, v1, changes the SQLState to 25001 for both connection types. As argued by Dag, this is in accordance with the SQL spec.

Suites.all and derbyall run cleanly. 

> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2065
>                 URL: https://issues.apache.org/jira/browse/DERBY-2065
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Network Server
>            Reporter: Bernt M. Johnsen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-2065_1.diff, derby-2065_1.stat
>
>
> Network and embedded difference in SQLSTATE and message when Connection.close() with open transaction.
> ----------- NetworkClient --------------
> Message: Cannot close a connection while a transaction is still active.
> SQLState: 25001
> ----------- Embedded --------------
> Message: Invalid transaction state.
> SQLState: 25000

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.