[jira] Closed: (DIRMINA-447) Allow adding more than one IoFilters of the same type.

["Trustin Lee (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee closed DIRMINA-447.
-------------------------------

    Resolution: Fixed
      Assignee: Trustin Lee

Now you can add multiple ExecutorFilters and ProtocolCodecFilters.  Some filters like SslFilter and CompressionFilter, that don't worth at all to add multiple times, still have the restriction but I won't fix it because of backward compatibility (i.e. public static attribute keys).

The following filter type, previously had the limitation, can be added more than once now:
* ExecutorFilter - SEDA has been realized.
* ProtocolCodecFilter - Multi-layered codec has been realized.

Other most filters were already OK to be added multiple times, so we can safely think this issue is fixed.



> Allow adding more than one IoFilters of the same type.
> ------------------------------------------------------
>
>                 Key: DIRMINA-447
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-447
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core, Filter
>            Reporter: Trustin Lee
>            Assignee: Trustin Lee
>             Fix For: 2.0.0-M1
>
>
> Currently, many existing filters such as ProtocolCodecFilter can't be added more than once to the same filter chain.  It is because filters usually store its state information as a session attribute; adding more than one filters of the same type will mess their internal state.
> Therefore, users can't do something more complex like multi-layered protocol implementation.
> To resolve this issue, all filter implementations must create its session attribute key dynamically, instead of using a static key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.