You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ygy <gi...@git.apache.org> on 2016/03/25 14:46:53 UTC

[GitHub] brooklyn-library pull request: Fix: ElasticSearch used Java versio...

GitHub user ygy opened a pull request:

    https://github.com/apache/brooklyn-library/pull/26

    Fix: ElasticSearch used Java version

    Making ElasticSearch to use JavaSoftwareProcessDriver so the correct
    java version is installed. ElasticSearch used to install java via
    BashCommands#installJavaLatestOrWarn(). It prevents setting the
    installed java version as default when:
    - the VM image comes with preinstalled jdk 6 or jdk7
    - CentOS version of JDK8 doesn't update the default automatically

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ygy/brooklyn-library fix/es-used-java

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-library/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit c8a450c039911f14dbf196aabdf0927ce543503e
Author: Yavor Yanchev <ya...@yanchev.com>
Date:   2016-03-25T13:44:27Z

    Fix: ElasticSearch used Java version
    
    Making ElasticSearch to use JavaSoftwareProcessDriver so the correct
    java version is installed. ElasticSearch used to install java via
    BashCommands#installJavaLatestOrWarn(). It prevents setting the
    installed java version as default when:
    - the VM image comes with preinstalled jdk 6 or jdk7
    - CentOS version of JDK8 doesn't update the default automatically

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library pull request: Fix: ElasticSearch used Java versio...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-library/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library pull request: Fix: ElasticSearch used Java versio...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/brooklyn-library/pull/26#issuecomment-201345935
  
    Have chatted with @ygy - the changes mean we install Java 7 rather than Java 8. It seems that `yum install` for Java 7 will ensure it is at the head of the path, but doing the same for Java 8 will not.
    
    Confirmed it worked with the `us-west-2/ami-56e48766` (which it previously failed with).
    
    Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library pull request: Fix: ElasticSearch used Java versio...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/brooklyn-library/pull/26#issuecomment-201340025
  
    @ygy can you explain how this fixes it? Under the covers, it looks like it will still just call `BashCommands.installJava(...)` which will do the `yum install` but will not update the CentOS `alternatives` to point at the new Java.
    
    Or does `JavaSoftwareProcessSshDriver` do something else to get the right (newer) java on the path?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---