You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jimmy Xiang <jx...@cloudera.com> on 2012/08/11 00:46:11 UTC

Fwd: [jira] [Commented] (HBASE-5728) Methods Missing in HTableInterface

Hi Bing,

Are you working on this issue?

Based on comments, at least the following methods should be added to
HTableInterface:

  public HConnection getConnection();

  public byte[][] getStartKeys() throws IOException;
  public byte[][] getEndKeys() throws IOException;
  public Pair<byte[][], byte[][]> getStartEndKeys() throws IOException;

  public void setAutoFlush(boolean autoFlush);
  public void setAutoFlush(boolean autoFlush, boolean clearBufferOnFail);

  public long getWriteBufferSize();
  public void setWriteBufferSize(long writeBufferSize) throws IOException,

Thanks,
Jimmy


---------- Forwarded message ----------
From: Lars Hofhansl (JIRA) <ji...@apache.org>
Date: Tue, Jul 31, 2012 at 12:01 PM
Subject: [jira] [Commented] (HBASE-5728) Methods Missing in HTableInterface
To: issues@hbase.apache.org



    [ https://issues.apache.org/jira/browse/HBASE-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426024#comment-13426024
]

Lars Hofhansl commented on HBASE-5728:
--------------------------------------

These:
{code}
public Map<HRegionInfo, HServerAddress> getRegionsInfo() throws IOException;
public HRegionLocation getRegionLocation(String row) throws IOException;
public HRegionLocation getRegionLocation(byte[] row) throws IOException;

public void prewarmRegionCache(Map<HRegionInfo, HServerAddress> regionMap);
public void clearRegionCache();

public long getWriteBufferSize();
public void setWriteBufferSize(long writeBufferSize) throws IOException,
public ArrayList<Put> getWriteBuffer();
{code}


Would leak implementation stuff into the interface.
I think HBASE-4054 specifically mentions, that {code}public
Map<HRegionInfo, HServerAddress> getRegionsInfo() throws
IOException;{code} is needed. Hmm...


> Methods Missing in HTableInterface
> ----------------------------------
>
>                 Key: HBASE-5728
>                 URL: https://issues.apache.org/jira/browse/HBASE-5728
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Bing Li
>
> Dear all,
> I found some methods existed in HTable were not in HTableInterface.
>    setAutoFlush
>    setWriteBufferSize
>    ...
> In most cases, I manipulate HBase through HTableInterface from HTablePool. If I need to use the above methods, how to do that?
> I am considering writing my own table pool if no proper ways. Is it fine?
> Thanks so much!
> Best regards,
> Bing

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (HBASE-5728) Methods Missing in HTableInterface

Posted by Jimmy Xiang <jx...@cloudera.com>.
getConnection is also deprecated.

On Fri, Aug 10, 2012 at 3:46 PM, Jimmy Xiang <jx...@cloudera.com> wrote:
> Hi Bing,
>
> Are you working on this issue?
>
> Based on comments, at least the following methods should be added to
> HTableInterface:
>
>   public HConnection getConnection();
>
>   public byte[][] getStartKeys() throws IOException;
>   public byte[][] getEndKeys() throws IOException;
>   public Pair<byte[][], byte[][]> getStartEndKeys() throws IOException;
>
>   public void setAutoFlush(boolean autoFlush);
>   public void setAutoFlush(boolean autoFlush, boolean clearBufferOnFail);
>
>   public long getWriteBufferSize();
>   public void setWriteBufferSize(long writeBufferSize) throws IOException,
>
> Thanks,
> Jimmy
>
>
> ---------- Forwarded message ----------
> From: Lars Hofhansl (JIRA) <ji...@apache.org>
> Date: Tue, Jul 31, 2012 at 12:01 PM
> Subject: [jira] [Commented] (HBASE-5728) Methods Missing in HTableInterface
> To: issues@hbase.apache.org
>
>
>
>     [ https://issues.apache.org/jira/browse/HBASE-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426024#comment-13426024
> ]
>
> Lars Hofhansl commented on HBASE-5728:
> --------------------------------------
>
> These:
> {code}
> public Map<HRegionInfo, HServerAddress> getRegionsInfo() throws IOException;
> public HRegionLocation getRegionLocation(String row) throws IOException;
> public HRegionLocation getRegionLocation(byte[] row) throws IOException;
>
> public void prewarmRegionCache(Map<HRegionInfo, HServerAddress> regionMap);
> public void clearRegionCache();
>
> public long getWriteBufferSize();
> public void setWriteBufferSize(long writeBufferSize) throws IOException,
> public ArrayList<Put> getWriteBuffer();
> {code}
>
>
> Would leak implementation stuff into the interface.
> I think HBASE-4054 specifically mentions, that {code}public
> Map<HRegionInfo, HServerAddress> getRegionsInfo() throws
> IOException;{code} is needed. Hmm...
>
>
>> Methods Missing in HTableInterface
>> ----------------------------------
>>
>>                 Key: HBASE-5728
>>                 URL: https://issues.apache.org/jira/browse/HBASE-5728
>>             Project: HBase
>>          Issue Type: Improvement
>>          Components: client
>>            Reporter: Bing Li
>>
>> Dear all,
>> I found some methods existed in HTable were not in HTableInterface.
>>    setAutoFlush
>>    setWriteBufferSize
>>    ...
>> In most cases, I manipulate HBase through HTableInterface from HTablePool. If I need to use the above methods, how to do that?
>> I am considering writing my own table pool if no proper ways. Is it fine?
>> Thanks so much!
>> Best regards,
>> Bing
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira