You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Patrick0308 (GitHub)" <gi...@apache.org> on 2020/03/24 12:22:42 UTC

[GitHub] [dubbo-go] Patrick0308 opened pull request #455: (WIP) Align 2.7.5: direct event dispatcher

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #450

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on issue #455: Align 2.7.5: direct event dispatcher

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
I can't find any failed message in CI testing.

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
hi, guy, compare map in this way,

obj, ok := m[]; !ok || obj == nil

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=h1) Report
> Merging [#455](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `54.90%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/455/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree)

```diff
@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #455      +/-   ##
=======================================================
+ Coverage                66.93%   67.04%   +0.11%     
=======================================================
  Files                      176      181       +5     
  Lines                     9342     9444     +102     
=======================================================
+ Hits                      6253     6332      +79     
- Misses                    2476     2496      +20     
- Partials                   613      616       +3     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/observer/event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/observer/event\_listener.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | |
| [common/observer/event.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50Lmdv) | `16.66% <16.66%> (ø)` | |
| [...mon/observer/dispatcher/direct\_event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2Rpc3BhdGNoZXIvZGlyZWN0X2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `69.23% <69.23%> (ø)` | |
| [common/observer/listenable.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2xpc3RlbmFibGUuZ28=) | `69.64% <69.64%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `58.91% <100.00%> (+2.00%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <0.00%> (-2.81%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.18% <0.00%> (-0.95%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=footer). Last update [adae0d7...357f536](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #455: Align 2.7.5: direct event dispatcher

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=h1) Report
> Merging [#455](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `52.83%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/455/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree)

```diff
@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #455      +/-   ##
=======================================================
+ Coverage                66.93%   67.02%   +0.09%     
=======================================================
  Files                      176      181       +5     
  Lines                     9342     9480     +138     
=======================================================
+ Hits                      6253     6354     +101     
- Misses                    2476     2505      +29     
- Partials                   613      621       +8     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/observer/event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | |
| [common/observer/event.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50Lmdv) | `16.66% <16.66%> (ø)` | |
| [common/observer/listenable.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2xpc3RlbmFibGUuZ28=) | `63.15% <63.15%> (ø)` | |
| [...mon/observer/dispatcher/direct\_event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2Rpc3BhdGNoZXIvZGlyZWN0X2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `75.00% <75.00%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `58.91% <100.00%> (+2.00%)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `82.71% <0.00%> (-2.10%)` | :arrow_down: |
| [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `71.08% <0.00%> (-1.76%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.18% <0.00%> (-0.95%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=footer). Last update [adae0d7...a782838](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on pull request #455: Align 2.7.5: direct event dispatcher

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
I want to know why `observer` is set in `common`. Who will use it.

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the comment.

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #455: Align 2.7.5: direct event dispatcher

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=h1) Report
> Merging [#455](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `52.83%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/455/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree)

```diff
@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #455      +/-   ##
=======================================================
+ Coverage                66.93%   67.02%   +0.09%     
=======================================================
  Files                      176      181       +5     
  Lines                     9342     9480     +138     
=======================================================
+ Hits                      6253     6354     +101     
- Misses                    2476     2505      +29     
- Partials                   613      621       +8     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/observer/event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | |
| [common/observer/event.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50Lmdv) | `16.66% <16.66%> (ø)` | |
| [common/observer/listenable.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2xpc3RlbmFibGUuZ28=) | `63.15% <63.15%> (ø)` | |
| [...mon/observer/dispatcher/direct\_event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2Rpc3BhdGNoZXIvZGlyZWN0X2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `75.00% <75.00%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `58.91% <100.00%> (+2.00%)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `82.71% <0.00%> (-2.10%)` | :arrow_down: |
| [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `71.08% <0.00%> (-1.76%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.18% <0.00%> (-0.95%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=footer). Last update [adae0d7...a782838](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash closed pull request #455: Align 2.7.5: direct event dispatcher

Posted by "flycash (GitHub)" <gi...@apache.org>.
[ pull request closed by flycash ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
comment


[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the comment.

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #455: (WIP) Align 2.7.5: direct event dispatcher

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
^_^

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #455: Align 2.7.5: direct event dispatcher

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=h1) Report
> Merging [#455](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7?src=pr&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `54.12%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/455/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree)

```diff
@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #455      +/-   ##
=======================================================
- Coverage                66.93%   66.76%   -0.17%     
=======================================================
  Files                      176      181       +5     
  Lines                     9342     9451     +109     
=======================================================
+ Hits                      6253     6310      +57     
- Misses                    2476     2518      +42     
- Partials                   613      623      +10
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | :arrow_up: |
| [common/observer/event\_listener.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2xpc3RlbmVyLmdv) | `0% <0%> (ø)` | |
| [common/observer/event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `0% <0%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `58.91% <100%> (+2%)` | :arrow_up: |
| [common/observer/event.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2V2ZW50Lmdv) | `16.66% <16.66%> (ø)` | |
| [common/observer/listenable.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2xpc3RlbmFibGUuZ28=) | `65% <65%> (ø)` | |
| [...mon/observer/dispatcher/direct\_event\_dispatcher.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y29tbW9uL29ic2VydmVyL2Rpc3BhdGNoZXIvZGlyZWN0X2V2ZW50X2Rpc3BhdGNoZXIuZ28=) | `75% <75%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0%> (-1.89%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0%> (-0.66%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/455/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=footer). Last update [adae0d7...2925dd3](https://codecov.io/gh/apache/dubbo-go/pull/455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on pull request #455: Align 2.7.5: direct event dispatcher

Posted by "Patrick0308 (GitHub)" <gi...@apache.org>.
At first, I think so. But it can't be fixed about the problem of circular dependency, because of  extension package dependency on observer's interface and registry's interface, registry's implement dependency on extension package, observer's interface and registry's interface.

[ Full content available at: https://github.com/apache/dubbo-go/pull/455 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org