[jira] [Commented] (FLINK-4132) Fix boxed comparison in CommunityDetection algorithm

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355349#comment-15355349 ] 

ASF GitHub Bot commented on FLINK-4132:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2185

    [FLINK-4132] [gelly] Fix boxed comparison in CommunityDetection algorithm

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 4132_fix_boxed_comparison_in_communitydetection_algorithm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2185
    
----
commit cf3f54674a7fbbb5f3f0e4b6c958ad241f0edb3b
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-06-29T14:43:41Z

    [FLINK-4132] [gelly] Fix boxed comparison in CommunityDetection algorithm

----


> Fix boxed comparison in CommunityDetection algorithm
> ----------------------------------------------------
>
>                 Key: FLINK-4132
>                 URL: https://issues.apache.org/jira/browse/FLINK-4132
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> IntelliJ notes that testing boxed primitives for equality will compare pointer values. We should be using primitives types.
> {code}
> if (maxScoreLabel != vertex.getValue().f0) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)