You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/13 13:45:31 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
pandaapo opened a new pull request, #3919:
URL: https://github.com/apache/eventmesh/pull/3919
Fixes #3918.
### Motivation
See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/3918#issue-1708596207).
### Modifications
See "Describe the solution you'd like" in [issue](https://github.com/apache/eventmesh/issues/3918#issue-1708596207).
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3919:
URL: https://github.com/apache/eventmesh/pull/3919#issuecomment-1566846954
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3919](https://app.codecov.io/gh/apache/eventmesh/pull/3919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ac5b969) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ce8d57) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ac5b969 differs from pull request most recent head 5fba851. Consider uploading reports for the commit 5fba851 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3919 +/- ##
============================================
- Coverage 14.24% 14.23% -0.01%
Complexity 1320 1320
============================================
Files 579 579
Lines 28967 28945 -22
Branches 2802 2788 -14
============================================
- Hits 4125 4121 -4
+ Misses 24450 24433 -17
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/admin/rocketmq/util/RequestMapping.java](https://app.codecov.io/gh/apache/eventmesh/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWFkbWluL2V2ZW50bWVzaC1hZG1pbi1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2FkbWluL3JvY2tldG1xL3V0aWwvUmVxdWVzdE1hcHBpbmcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...entmesh/admin/rocketmq/util/UrlMappingPattern.java](https://app.codecov.io/gh/apache/eventmesh/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWFkbWluL2V2ZW50bWVzaC1hZG1pbi1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2FkbWluL3JvY2tldG1xL3V0aWwvVXJsTWFwcGluZ1BhdHRlcm4uamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3919/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3919:
URL: https://github.com/apache/eventmesh/pull/3919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3919:
URL: https://github.com/apache/eventmesh/pull/3919#issuecomment-1549053773
Yes, it has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3919:
URL: https://github.com/apache/eventmesh/pull/3919#issuecomment-1548856372
> please check checkstyle.
It seems not my responsibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3919: [ISSUE #3918]RequestMapping, UrlMappingPattern can apply some optimizing
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3919:
URL: https://github.com/apache/eventmesh/pull/3919#issuecomment-1547278039
please check checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org