You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by GitBox <gi...@apache.org> on 2022/01/14 16:11:49 UTC

[GitHub] [manifoldcf] mguenther opened a new pull request #112: Add non-emptiness clause to realm check of Solr output connector

mguenther opened a new pull request #112:
URL: https://github.com/apache/manifoldcf/pull/112


   The underlying HTTP client of the Solr output connector always configures a dedicated `AuthScope` of the connection, even if the provided `realm` is the empty string (`""`). This is due to the fact that the attribute `realm` is never `null`, but `""` in case the user did not supply a parameter for this. This breaks connectivity in case basic authentication is in-place, but no realm is required. Thus, in both cases (`null` value and `""` for realm) the HTTP client should use `AuthScope.ANY`. This commit adds the necessary non-emptiness clause to the realm check in order to fix this behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@manifoldcf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [manifoldcf] schuch commented on pull request #112: Add non-emptiness clause to realm check of Solr output connector

Posted by GitBox <gi...@apache.org>.
schuch commented on pull request #112:
URL: https://github.com/apache/manifoldcf/pull/112#issuecomment-1013699629


   Raised https://issues.apache.org/jira/browse/CONNECTORS-1693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@manifoldcf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [manifoldcf] asfgit closed pull request #112: Add non-emptiness clause to realm check of Solr output connector

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #112:
URL: https://github.com/apache/manifoldcf/pull/112


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@manifoldcf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [manifoldcf] schuch commented on pull request #112: Add non-emptiness clause to realm check of Solr output connector

Posted by GitBox <gi...@apache.org>.
schuch commented on pull request #112:
URL: https://github.com/apache/manifoldcf/pull/112#issuecomment-1013707973


   The patch was accepted with c004b1c3a17d84852997eefd488df8647e19a7ee
   Many thanks for the contribution Markus! ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@manifoldcf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org