You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/10 13:48:13 UTC
[GitHub] [submarine] FatalLin opened a new pull request #602: SUBMARINE-844/ allow notebook operation could work on assigned namespace
FatalLin opened a new pull request #602:
URL: https://github.com/apache/submarine/pull/602
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? Yes/No
* Are there breaking changes for older versions? Yes/No
* Does this need new documentation? Yes/No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #602: SUBMARINE-844. allow notebook operation could work on assigned namespace
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #602:
URL: https://github.com/apache/submarine/pull/602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #602: SUBMARINE-844. allow notebook operation could work on assigned namespace
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #602:
URL: https://github.com/apache/submarine/pull/602#discussion_r650409365
##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -268,8 +268,8 @@ public TensorboardInfo getTensorboardInfo() throws SubmarineRuntimeException {
final String name = "submarine-tensorboard";
final String ingressRouteName = "submarine-tensorboard-ingressroute";
String namespace = "default";
- if (System.getenv(ENV_NAMESPACE) != null) {
- namespace = System.getenv(ENV_NAMESPACE);
+ if (System.getProperty(ENV_NAMESPACE) != null) {
+ namespace = System.getProperty(ENV_NAMESPACE);
Review comment:
getenv
##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -268,8 +268,8 @@ public TensorboardInfo getTensorboardInfo() throws SubmarineRuntimeException {
final String name = "submarine-tensorboard";
final String ingressRouteName = "submarine-tensorboard-ingressroute";
String namespace = "default";
- if (System.getenv(ENV_NAMESPACE) != null) {
- namespace = System.getenv(ENV_NAMESPACE);
+ if (System.getProperty(ENV_NAMESPACE) != null) {
Review comment:
getenv
##########
File path: submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -412,16 +427,22 @@ public Notebook deleteNotebook(NotebookSpec spec) throws SubmarineRuntimeExcepti
final String name = spec.getMeta().getName();
final String pvName = NotebookUtils.PV_PREFIX + name;
final String pvcName = NotebookUtils.PVC_PREFIX + name;
+ String namespace = "default";
+
+ if (System.getProperty(ENV_NAMESPACE) != null) {
Review comment:
getenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] FatalLin commented on pull request #602: [WIP]SUBMARINE-844. allow notebook operation could work on assigned namespace
Posted by GitBox <gi...@apache.org>.
FatalLin commented on pull request #602:
URL: https://github.com/apache/submarine/pull/602#issuecomment-859172994
@xunliu sure, I just created this PR before the operator weekly syncup meeting, as you can see the description is still missing so I add a working in process prefix there. Definitely will fix title once the description is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org