You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/05/22 12:29:35 UTC
[GitHub] [maven-mvnd] ppalaga opened a new issue, #852: Shouldn't `JAVA_HOME` be discriminating?
ppalaga opened a new issue, #852:
URL: https://github.com/apache/maven-mvnd/issues/852
I guess yes, at least for the sake of documenting it.
I see that in `DaemonCompatibilitySpec`, it has a special position among the other discriminating options. But still, it is de facto discriminating, so we should put the discriminating flag on it. WDYT @gnodet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #852: `JAVA_HOME` should be discriminating
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on issue #852:
URL: https://github.com/apache/maven-mvnd/issues/852#issuecomment-1557138333
I have added a commit to https://github.com/apache/maven-mvnd/pull/851 - so @gnodet please veto that one if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #852: `JAVA_HOME` should be discriminating
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on issue #852:
URL: https://github.com/apache/maven-mvnd/issues/852#issuecomment-1557600479
> it may better to add some javadoc that will end-up in the help
Good idea. Let me do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #852: `JAVA_HOME` should be discriminating
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on issue #852:
URL: https://github.com/apache/maven-mvnd/issues/852#issuecomment-1557462948
> I have added a commit to #851 - so @gnodet please veto that one if needed.
I think it should be documented as discriminated, but it is handled specifically in a bunch of cases (as shown by the failings ITs), I think it may better to add some javadoc that will end-up in the help, wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `JAVA_HOME` should be documented as discriminating [maven-mvnd]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on issue #852:
URL: https://github.com/apache/maven-mvnd/issues/852#issuecomment-6249606895
Fixed in https://github.com/apache/maven-mvnd/pull/851 (since 1.0-m7): `JAVA_HOME` is flagged as discriminating in `mvnd --help`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `JAVA_HOME` should be documented as discriminating [maven-mvnd]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed issue #852: `JAVA_HOME` should be documented as discriminating
URL: https://github.com/apache/maven-mvnd/issues/852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org