You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/27 05:21:36 UTC
Review Request 70318: Added `empty()` method in `class
ResourceQuantities`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70318/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added `empty()` method in `class ResourceQuantities`.
Diffs
-----
src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66
Diff: https://reviews.apache.org/r/70318/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70318: Added `empty()` method in `class
ResourceQuantities`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70318/
-----------------------------------------------------------
(Updated March 29, 2019, 3:33 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Added `empty()` method in `class ResourceQuantities`.
Diffs (updated)
-----
src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66
Diff: https://reviews.apache.org/r/70318/diff/2/
Changes: https://reviews.apache.org/r/70318/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70318: Added `empty()` method in `class
ResourceQuantities`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70318/#review214108
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On March 27, 2019, 5:21 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70318/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 5:21 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `empty()` method in `class ResourceQuantities`.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66
>
>
> Diff: https://reviews.apache.org/r/70318/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>