You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/05/22 04:49:29 UTC
Re: Review Request 30606: Added net::contentLength() to query
"content-length" field from HTTP header.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30606/#review84855
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 28, 2015, 2:51 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30606/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 2:51 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
>
>
> Bugs: MESOS-2072
> https://issues.apache.org/jira/browse/MESOS-2072
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds net::contentLength(). This makes a short HTTP request to read the "content-length" field from the HTTP header.
>
> This will be used to determine the size of a file before downloading it to the fetcher cache, in order to ensure there is enough space ahead of time.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 9635bbc6f7dae1d75a780069fcc60fb706221053
>
> Diff: https://reviews.apache.org/r/30606/diff/
>
>
> Testing
> -------
>
> Used this function in the context of my implementation of MESOS-2072 and MESOS-2074. It correctly reported the content length from an HTTP server constructed from libprocess primitives.
>
>
> Thanks,
>
> Bernd Mathiske
>
>