[jira] [Commented] (AMBARI-20407) When agent retries commands it needs to handle credential store processing correctly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-20407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906502#comment-15906502 ] 

Hadoop QA commented on AMBARI-20407:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12857512/AMBARI-20407.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-agent.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10983//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10983//console

This message is automatically generated.

> When agent retries commands it needs to handle credential store processing correctly
> ------------------------------------------------------------------------------------
>
>                 Key: AMBARI-20407
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20407
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-agent
>    Affects Versions: 2.5.0
>            Reporter: Sumit Mohanty
>            Assignee: Sumit Mohanty
>            Priority: Critical
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-20407.patch
>
>
> Credential store handling has a one-way logic to move passwords to jceks files and then removing the passwords from the configs. When agent does an auto-retry of command execution then the initial assumption of relying on the existence of the "password" properties no longer holds true. This incorrectly disables credential store but as passwords are no longer available it results in broken configurations.
> The solution here is to avoid processing the password properties when command is an implicit retry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)