You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "gaoran10 (via GitHub)" <gi...@apache.org> on 2023/03/16 05:02:03 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request, #19829: [fix][test] Improve test metadata store stats
gaoran10 opened a new pull request, #19829:
URL: https://github.com/apache/pulsar/pull/19829
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Master Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lifepuzzlefun commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "lifepuzzlefun (via GitHub)" <gi...@apache.org>.
lifepuzzlefun commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1474660889
I agree with you. I think the best fix is to change the failed unit test. maybe my first try in a wrong direction （to find the not close metdatastore） : - )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yyj8 commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "yyj8 (via GitHub)" <gi...@apache.org>.
yyj8 commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1471817853
I encountered the same problem as you. Yesterday, a PR(https://github.com/apache/pulsar/pull/19793) in the community said that the bug was fixed. I merged it, but running ci still made the same error.
ERROR LOG:
```
Error: org.apache.pulsar.broker.stats.MetadataStoreStatsTest.testBatchMetadataStoreMetrics(org.apache.pulsar.broker.stats.MetadataStoreStatsTest)
[INFO] Run 1: PASS
Error: Run 2: MetadataStoreStatsTest.testBatchMetadataStoreMetrics:199 Assertion failed with metrics:
Error: Tests run: 15, Failures: 1, Errors: 0, Skipped: 14, Time elapsed: 8.296 s <<< FAILURE! - in org.apache.pulsar.broker.stats.MetadataStoreStatsTest
Error: testBatchMetadataStoreMetrics(org.apache.pulsar.broker.stats.MetadataStoreStatsTest) Time elapsed: 0.505 s <<< FAILURE!
java.lang.AssertionError:
Assertion failed with metrics:
pulsar_managedLedger_client_bookkeeper_ml_scheduler_task_queued_sum{cluster="test", success="true"} 163.0
expected object to not be null
at org.testng.Assert.fail(Assert.java:110)
at org.testng.Assert.assertNotNull(Assert.java:1319)
at org.apache.pulsar.broker.stats.MetadataStoreStatsTest.testBatchMetadataStoreMetrics(MetadataStoreStatsTest.java:199)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
at org.testng.internal.invokers.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:47)
at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:76)
at org.testng.internal.invokers.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Error: Failures:
Error: org.apache.pulsar.broker.stats.MetadataStoreStatsTest.testBatchMetadataStoreMetrics(org.apache.pulsar.broker.stats.MetadataStoreStatsTest)
[INFO] Run 1: PASS
Error: Run 2: MetadataStoreStatsTest.testBatchMetadataStoreMetrics:199 Assertion failed with metrics:
# TYPE pulsar_version_info gauge
# TYPE pulsar_batch_metadata_store_executor_queue_size gauge
pulsar_batch_metadata_store_executor_queue_size{cluster="test",name="configuration-metadata-store"} 1.0
pulsar_batch_metadata_store_executor_queue_size{cluster="test",name="metadata-store"} 1.0
pulsar_batch_metadata_store_executor_queue_size{cluster="test",name=""} 1.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19829:
URL: https://github.com/apache/pulsar/pull/19829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "gaoran10 (via GitHub)" <gi...@apache.org>.
gaoran10 commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1473049412
@yyj8 I think the problem is other tests may generate metadata store metrics without a metadata name, I change this test only check metrics with the names `metadata-store` and `configuration-metadata-store`, I think we can fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dao-jun commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1472422842
there is a related PR https://github.com/apache/pulsar/pull/19793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "gaoran10 (via GitHub)" <gi...@apache.org>.
gaoran10 commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1473079920
I think we have three options.
1. Only check metrics with names `metadata-store` and `configuration-metadata-store`.
2. Clean up metrics before this test.
3. Specify a metadata name while generating `MetadataStoreConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19829: [fix][test] Improve test metadata store stats
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19829: [fix][test] Improve test metadata store stats
URL: https://github.com/apache/pulsar/pull/19829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "gaoran10 (via GitHub)" <gi...@apache.org>.
gaoran10 commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1471578238
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #19829: [fix][test] Fix flaky MetadataStoreStatsTest
Posted by "gaoran10 (via GitHub)" <gi...@apache.org>.
gaoran10 commented on PR #19829:
URL: https://github.com/apache/pulsar/pull/19829#issuecomment-1473050521
@dao-jun I think we can only check metadata metrics with names `metadata-store` and `configuration-metadata-store`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #19829: [fix][test] Improve test metadata store stats
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #19829: [fix][test] Improve test metadata store stats
URL: https://github.com/apache/pulsar/pull/19829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org