[jira] Issue Comment Edited: (BUILDR-324) Regression: baseDir system property is not set when executing tests

["Alex Boisvert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761034#action_12761034 ] 

Alex Boisvert edited comment on BUILDR-324 at 9/30/09 5:05 PM:
---------------------------------------------------------------

Patch applied.

boisvert@sixtine:~/svn/buildr-324$ svn commit -m "BUILDR-324: Regression - baseDir system property is not set when executing tests"
Sending        CHANGELOG
Sending        lib/buildr/core/test.rb
Sending        spec/java/tests_spec.rb
Transmitting file data ...
Committed revision 820485.

The reason why the original patch didn't work was due to using @project.compile.target instead of @project.test.compile.target

      was (Author: boisvert):
    Patch applied.

boisvert@sixtine:~/svn/buildr-324$ svn commit -m "BUILDR-324: Regression - baseDir system property is not set when executing tests"
Sending        CHANGELOG
Sending        lib/buildr/core/test.rb
Sending        spec/java/tests_spec.rb
Transmitting file data ...
Committed revision 820485.

The reason why the original patch didn't work was due to a Ruby wart -- using @project inside the hash literal,

+          @framework.options[:properties] = { 'baseDir' => @project.test.compile.target.to_s }.merge(@framework.options[:properties] || {})

This variation fixed the issue,

+          target = @project.test.compile.target.to_s
+          @framework.options[:properties] = { 'baseDir' => target }.merge(@framework.options[:properties] || {})

  
> Regression: baseDir system property is not set when executing tests 
> --------------------------------------------------------------------
>
>                 Key: BUILDR-324
>                 URL: https://issues.apache.org/jira/browse/BUILDR-324
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3, 1.3.1, 1.3.2, 1.3.3, 1.3.4
>            Reporter: Alexis Midon
>            Assignee: Alex Boisvert
>             Fix For: 1.3.5
>
>         Attachments: buildr-324.0.patch
>
>
> Commit 327819b0964a7c  (r606431) introduced a regression.
> The baseDir system property used to be set to test.compile.target when running the tests.
> http://github.com/apache/buildr/commit/327819b0964a7c32b14d03527cb765d598b70dea

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.